-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docker local environment #10993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docker local environment #10993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a containerized local development environment for CloudStack and MySQL on macOS.
- Adds a MySQL initialization script and an entrypoint script to set up and start MySQL and CloudStack services.
- Provides a Docker Compose configuration and a Dockerfile to build and orchestrate the containers.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
docker-local-environment/init-mysql.sh | Bash script to wait for and initialize MySQL, creating the required database and user. |
docker-local-environment/docker-entrypoint.sh | Bash script to start MySQL, run initialization, start CloudStack, and keep the container running. |
docker-local-environment/docker-compose.yml | Compose file to set up the MySQL and CloudStack services with proper dependency handling and networking. |
docker-local-environment/Dockerfile | Dockerfile to build an Ubuntu-based image, install dependencies, and compile CloudStack from source. |
service cloudstack-management start | ||
|
||
# Keep the container running | ||
exec bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command 'exec bash' at line 24 will replace the current shell, making the subsequent 'tail -f /dev/null' unreachable. Consider removing one of these commands to keep the container running as intended.
exec bash |
Copilot uses AI. Check for mistakes.
gnupg \ | ||
openjdk-17-jdk \ | ||
maven \ | ||
python3 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure there is no trailing whitespace after the backslash in this installation command to prevent potential build issues. This can help avoid unexpected errors during the Docker build process.
python3 \ | |
python3 \ |
Copilot uses AI. Check for mistakes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10993 +/- ##
============================================
- Coverage 16.57% 16.57% -0.01%
+ Complexity 13870 13869 -1
============================================
Files 5719 5719
Lines 507200 507200
Branches 61574 61574
============================================
- Hits 84093 84089 -4
- Misses 413688 413692 +4
Partials 9419 9419
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thanks for the sharing @bri-harris my opinions
|
Description
This PR...
As a MacOS user, I need a Docker environment which packages all the necessary dependencies in order to locally work on cloudstack. This PR introduces containerization of services like cloudstack and mysql.
Feature Request: #10967
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
I have run this on my local machine, I am able to spin up a container with the Cloudstack Project and connect a MySQL container with the correct table and information