replace key lookups with value() calls in BaremetalManager

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: 2 people

plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/manager/BareMetalDiscoverer.java

@@ -160,7 +160,7 @@ public Map<? extends ServerResource, Map<String, String>> find(long dcId, Long p
             params.put("vmDao", _vmDao);
             params.put("configDao", _configDao);
 
-            String resourceClassName = _configDao.getValue(BaremetalManager.ExternalBaremetalResourceClassName.key());
+            String resourceClassName = BaremetalManager.ExternalBaremetalResourceClassName.value();
             BareMetalResourceBase resource = null;
             if (resourceClassName != null) {
                 Class<?> clazz = Class.forName(resourceClassName);
@@ -193,7 +193,7 @@ public Map<? extends ServerResource, Map<String, String>> find(long dcId, Long p
             if (vmIp != null) {
                 details.put(ApiConstants.IP_ADDRESS, vmIp);
             }
-            String isEchoScAgent = _configDao.getValue(BaremetalManager.EnableBaremetalSecurityGroupAgentEcho.key());
+            String isEchoScAgent = String.valueOf(BaremetalManager.EnableBaremetalSecurityGroupAgentEcho.value());
             details.put(BaremetalManager.EchoSecurityGroupAgent, isEchoScAgent);
 
             resources.put(resource, details);

plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BareMetalResourceBase.java

@@ -172,20 +172,20 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
 
         String ipmiIface = "default";
         try {
-            ipmiIface = configDao.getValue(BaremetalManager.BaremetalIpmiLanInterface.key());
+            ipmiIface = BaremetalManager.BaremetalIpmiLanInterface.value();
         } catch (Exception e) {
             logger.debug(e.getMessage(), e);
         }
 
         try {
-            ipmiRetryTimes = Integer.parseInt(configDao.getValue(BaremetalManager.BaremetalIpmiRetryTimes.key()));
+            ipmiRetryTimes = Integer.parseInt(BaremetalManager.BaremetalIpmiRetryTimes.value());
         } catch (Exception e) {
             logger.debug(e.getMessage(), e);
         }
 
         try {
             provisionDoneNotificationOn = ManagementServer.BaremetalProvisionDoneNotificationEnabled.value();
-            isProvisionDoneNotificationTimeout = Integer.parseInt(configDao.getValue(BaremetalManager.BaremetalProvisionDoneNotificationTimeout.key()));
+            isProvisionDoneNotificationTimeout = BaremetalManager.BaremetalProvisionDoneNotificationTimeout.value();
         } catch (Exception e) {
             logger.debug(e.getMessage(), e);
         }

plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java

@@ -219,7 +219,7 @@ private boolean preparePxeInAdvancedZone(VirtualMachineProfile profile, NicProfi
             throw new CloudRuntimeException(String.format("Cannot find Management NIC on virtual router[id:%s]", vr.getId()));
         }
 
-        String internalServerIp = _configDao.getValue(BaremetalManager.BaremetalInternalStorageServer.key());
+        String internalServerIp = BaremetalManager.BaremetalInternalStorageServer.value();
         if (internalServerIp == null) {
             throw new CloudRuntimeException(String.format("please specify 'baremetal.internal.storage.server.ip', which is the http server/nfs server storing kickstart files and ISO files, in global setting"));
         }