replace key lookups with value() calls in DeploymentClusterPlanner

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: 2 people

plugins/deployment-planners/user-dispersing/src/main/java/com/cloud/deploy/UserDispersingPlanner.java

@@ -26,7 +26,6 @@
 import javax.naming.ConfigurationException;
 
 
-import com.cloud.utils.NumbersUtil;
 import com.cloud.utils.Pair;
 import com.cloud.vm.VirtualMachineProfile;
 
@@ -187,8 +186,7 @@ private List<Long> orderByApplyingWeights(Pair<List<Long>, Map<Long, Double>> ca
     public boolean configure(String name, Map<String, Object> params) throws ConfigurationException {
         super.configure(name, params);
 
-        String weight = configDao.getValue(VmUserDispersionWeight.key());
-        _userDispersionWeight = NumbersUtil.parseFloat(weight, 1.0f);
+        _userDispersionWeight = VmUserDispersionWeight.value();
 
         return true;
     }

server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java

@@ -287,7 +287,7 @@ private Pair<List<Long>, Map<Long, Double>> getOrderedHostsByCapacity(Long zoneI
         double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
         // Get capacity by which we should reorder
         short capacityType = FirstFitPlanner.getHostCapacityTypeToOrderCluster(
-                _configDao.getValue(DeploymentClusterPlanner.HostCapacityTypeToOrderClusters.key()), cpuToMemoryWeight);
+                DeploymentClusterPlanner.HostCapacityTypeToOrderClusters.value(), cpuToMemoryWeight);
         logger.debug("CapacityType: {} is used for Host ordering", FirstFitPlanner.getCapacityTypeName(capacityType));
         if (capacityType >= 0) { // for CPU or RAM
             return _capacityDao.orderHostsByFreeCapacity(zoneId, clusterId, capacityType);

server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java

@@ -376,7 +376,7 @@ public DeployDestination planDeployment(VirtualMachineProfile vmProfile, Deploym
                 } else if (vm.getHypervisorType() == HypervisorType.External) {
                     plannerName = "ExternalServerPlanner";
                 } else {
-                    plannerName = _configDao.getValue(VmDeploymentPlanner.key());
+                    plannerName = VmDeploymentPlanner.value();
                 }
             }
             planner = getDeploymentPlannerByName(plannerName);

server/src/main/java/com/cloud/deploy/FirstFitPlanner.java

@@ -182,7 +182,7 @@ public List<Long> orderClusters(VirtualMachineProfile vmProfile, DeploymentPlan
         } else {
             logger.debug("Searching all possible resources under this Zone: {}", dcDao.findById(plan.getDataCenterId()));
 
-            boolean applyAllocationAtPods = Boolean.parseBoolean(configDao.getValue(ApplyAllocationAlgorithmToPods.key()));
+            boolean applyAllocationAtPods = ApplyAllocationAlgorithmToPods.value();
             if (applyAllocationAtPods) {
                 //start scan at all pods under this zone.
                 clusterList = scanPodsForDestination(vmProfile, plan, avoid);
@@ -521,7 +521,7 @@ protected Pair<List<Long>, Map<Long, Double>> listPodsByCapacity(long zoneId, in
     private Pair<List<Long>, Map<Long, Double>> getOrderedPodsByCapacity(long zoneId) {
         double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
         short capacityType = getHostCapacityTypeToOrderCluster(
-                configDao.getValue(HostCapacityTypeToOrderClusters.key()), cpuToMemoryWeight);
+                HostCapacityTypeToOrderClusters.value(), cpuToMemoryWeight);
 
         logger.debug("CapacityType: {} is used for Pod ordering", getCapacityTypeName(capacityType));
         if (capacityType >= 0) { // for capacityType other than COMBINED
@@ -556,7 +556,7 @@ public Map<Long, Double> getPodByCombinedCapacities(List<CapacityVO> capacities,
     private Pair<List<Long>, Map<Long, Double>> getOrderedClustersByCapacity(long id, long vmId, boolean isZone) {
         double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
         short capacityType = getHostCapacityTypeToOrderCluster(
-                configDao.getValue(HostCapacityTypeToOrderClusters.key()), cpuToMemoryWeight);
+                HostCapacityTypeToOrderClusters.value(), cpuToMemoryWeight);
 
         logger.debug("CapacityType: {} is used for Cluster ordering", getCapacityTypeName(capacityType));
         if (capacityType >= 0) { // for capacityType other than COMBINED
@@ -667,7 +667,7 @@ public boolean canHandle(VirtualMachineProfile vm, DeploymentPlan plan, ExcludeL
     public boolean configure(String name, Map<String, Object> params) throws ConfigurationException {
         super.configure(name, params);
         allocationAlgorithm = VmAllocationAlgorithm.value();
-        globalDeploymentPlanner = configDao.getValue(DeploymentPlanningManager.VmDeploymentPlanner.key());
+        globalDeploymentPlanner = DeploymentPlanningManager.VmDeploymentPlanner.value();
         String configValue;
         if ((configValue = configDao.getValue(ImplicitHostTags.key())) != null) {
             implicitHostTags = configValue.trim().split("\\s*,\\s*");