Improve coder byte calculation methods #36830
Conversation
Makes IntervalWindowCoder::isRegisterByteSizeObserverCheap directly return true. Add getEncodedElementByteSize to PaneInfoCoder Add registerByteSizeObserver to ValueWithRecordIdCoder
|
R: @scwhittle |
Summary of ChangesHello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the efficiency of byte size calculation methods within several key Apache Beam coders. By simplifying checks, adding direct size calculation methods, and ensuring proper byte observation, these changes aim to reduce computational overhead and improve performance when dealing with data serialization and sizing in the Beam pipeline. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36830 +/- ##
============================================
- Coverage 40.33% 40.33% -0.01%
+ Complexity 3456 3455 -1
============================================
Files 1225 1225
Lines 187817 187820 +3
Branches 3586 3587 +1
============================================
- Hits 75762 75755 -7
- Misses 108665 108672 +7
- Partials 3390 3393 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| public boolean isRegisterByteSizeObserverCheap(IntervalWindow value) { | ||
| return instantCoder.isRegisterByteSizeObserverCheap(value.end) | ||
| && durationCoder.isRegisterByteSizeObserverCheap(new Duration(value.start, value.end)); | ||
| return true; |
There was a problem hiding this comment.
should we inline the DurationCoder logic and remove it? It is just varint and we could then avoid creating Duration objects
| public void verifyDeterministic() {} | ||
|
|
||
| @Override | ||
| protected long getEncodedElementByteSize(PaneInfo value) throws Exception { |
There was a problem hiding this comment.
can you add some unit tests creating various elements and comparing this and actual serialized size?
| @Override | ||
| public void verifyDeterministic() {} | ||
|
|
||
| @Override |
There was a problem hiding this comment.
nit: move method next to encode? more likely to see they both need to be modified
| @Override | ||
| public void registerByteSizeObserver( |
There was a problem hiding this comment.
should we implement the isCheap method as well, delegating to the coders?
| @Override | ||
| public void verifyDeterministic() {} | ||
|
|
||
| @Override |
There was a problem hiding this comment.
can you update PR description? It says we are encoding for every element to calculate the size, but since the cheap method returns false it should just be sampled elements.
2 participants
#33578