Make WindowedValue a public interface, and receivers for it #35140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennknowles
force-pushed
the
ValueWithMetadataReceiver
branch
from
6c80b72 to
fcc7095
Compare
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
kennknowles
force-pushed
the
ValueWithMetadataReceiver
branch
from
fcc7095 to
1175409
Compare
kennknowles
force-pushed
the
ValueWithMetadataReceiver
branch
2 times, most recently
from
dbf9ced to
ca13974
Compare
3 tasks
kennknowles
force-pushed
the
ValueWithMetadataReceiver
branch
2 times, most recently
from
f175dee to
ebd6d09
Compare
kennknowles
changed the title
kennknowles
force-pushed
the
ValueWithMetadataReceiver
branch
from
ebd6d09 to
b7e7b0e
Compare
When we introduce OutputBuilder, it will implement WindowedValue, and every time we create an OutputBuilder we will want to provide the following: 1. the default metadata for the output 2. the receiver for the output This change unblocks 2 and reduces the size of the final change.
kennknowles
force-pushed
the
ValueWithMetadataReceiver
branch
from
b7e7b0e to
6f56dbe
Compare
Member
Author
|
Actually I think I can make it even simpler and one huge totally automated change that doesn't need much review and the semi-useful changes in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary change to reduce the number of files to review in #34902
When we introduce OutputBuilder, it will implement WindowedValue, and every time we create an OutputBuilder we will want to provide
This change unblocks step 2 and reduces the size of the final change. The exact things done in this PR cause a lot of tiny changes but they are trivial:
WindowedValueout of internalutilpackage and into publicvalues.WindowedValuean interface (it was an abstract class for obsolete reasons for Java < 8, and we want other interfaces to be able to extend it)WindowedValuescompanion class for concrete implementations and static methods (that already exist).WindowedValueReceiverandWindowedValueMultiReceiverin the SDK (previously they were in runners/core) and use them. This simplifies and eliminates a decent chunk of runner code.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.