GH-47348: [Python] Include retry_strategy in S3FileSystem.__reduce__ #47350
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…uce__ method S3FileSystem's retry_strategy should survive serialization and deserialization. Signed-off-by: Kit Lee <[email protected]>
wingkitlee0
force-pushed
the
klee/retry_strategy
branch
from
bd294f1 to
983021c
Compare
|
@github-actions crossbow submit -g python |
|
Revision: 983021c Submitted crossbow builds: ursacomputing/crossbow @ actions-19f6d98dfd
|
github-actions
bot
added
awaiting merge
pitrou
requested changes
Aug 21, 2025
|
|
||
| fs = S3FileSystem( | ||
| retry_strategy=AwsDefaultS3RetryStrategy(max_attempts=5)) | ||
| assert isinstance(fs, S3FileSystem) | ||
| assert pickle_module.loads(pickle_module.dumps(fs)) == fs |
There was a problem hiding this comment.
Ok, but should also assert that it's different from a filesystem configured with another strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This change fixes the serialization/deserialization of
S3FileSystem. Previously theretry_strategyparameter is missed in the serialization. This affects other distributed library like Ray to incorrectly reconstruct aS3FileSystemwith no retry_strategy parameter in other processes.What changes are included in this PR?
This PR adds
retry_strategyinS3FileSystem.__reduce__and a property method to allow access toretry_strategy(a python object). SinceS3FileSystemis a cdef class butAWSDefaultRetryStrategyetc are not,objecttype is used for simplicity.Are these changes tested?
Updated the unit tests to test for
retry_strategy.Notably the
retry_strategyproperty can be used to verify the correct reconstruction.Are there any user-facing changes?
No.