Skip to content

GH-47259: [Dev] Use "issue type" not "issue label" for issue type #47340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kou
Copy link
Member

@kou kou commented Aug 15, 2025

Rationale for this change

GitHub introduced the "issue type" feature for issue type:

Let's use it not custom "issue label"s such as "Type: bug" and "Type: enhancement" for issue type.

What changes are included in this PR?

Use type: instead of labels: in issue templates.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #47259 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 15, 2025
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will break our current changelog generation, as we rely on the label Type::

issue_types = {
'Bug': 'Bug Fixes',
'Improvement': 'New Features and Improvements',
'New Feature': 'New Features and Improvements',
'Sub-task': 'New Features and Improvements',
'Task': 'New Features and Improvements',
'Test': 'Bug Fixes',
'Wish': 'New Features and Improvements',
'Type: bug': 'Bug Fixes',
'Type: enhancement': 'New Features and Improvements',
'Type: task': 'New Features and Improvements',
'Type: test': 'Bug Fixes',
'Type: usage': 'New Features and Improvements',
}

We should also change this probably:
def from_github(cls, github_issue):
return cls(
key=github_issue.number,
type=next(
iter(
[
label.name for label in github_issue.labels
if label.name.startswith("Type:")
]
), None),
summary=github_issue.title,
github_issue=github_issue
)

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Aug 18, 2025
@kou
Copy link
Member Author

kou commented Aug 18, 2025

Oh, sorry. I missed it.

It seems that PyGithub doesn't support issue type yet:

@raulcd
Copy link
Member

raulcd commented Aug 19, 2025

I saw @EnricoMi is a maintainer on PyGithub maybe he can help get a release soon as this was merged some days ago :)

@EnricoMi
Copy link
Contributor

Give me a few more days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes Awaiting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants