-
Notifications
You must be signed in to change notification settings - Fork 3.8k
GH-47259: [Dev] Use "issue type" not "issue label" for issue type #47340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will break our current changelog generation, as we rely on the label Type:
:
arrow/dev/archery/archery/release/core.py
Lines 460 to 473 in 7360515
issue_types = { | |
'Bug': 'Bug Fixes', | |
'Improvement': 'New Features and Improvements', | |
'New Feature': 'New Features and Improvements', | |
'Sub-task': 'New Features and Improvements', | |
'Task': 'New Features and Improvements', | |
'Test': 'Bug Fixes', | |
'Wish': 'New Features and Improvements', | |
'Type: bug': 'Bug Fixes', | |
'Type: enhancement': 'New Features and Improvements', | |
'Type: task': 'New Features and Improvements', | |
'Type: test': 'Bug Fixes', | |
'Type: usage': 'New Features and Improvements', | |
} |
We should also change this probably:
arrow/dev/archery/archery/release/core.py
Lines 71 to 83 in 7360515
def from_github(cls, github_issue): | |
return cls( | |
key=github_issue.number, | |
type=next( | |
iter( | |
[ | |
label.name for label in github_issue.labels | |
if label.name.startswith("Type:") | |
] | |
), None), | |
summary=github_issue.title, | |
github_issue=github_issue | |
) |
Oh, sorry. I missed it. It seems that PyGithub doesn't support issue type yet: |
I saw @EnricoMi is a maintainer on PyGithub maybe he can help get a release soon as this was merged some days ago :) |
Give me a few more days. |
Rationale for this change
GitHub introduced the "issue type" feature for issue type:
Let's use it not custom "issue label"s such as "Type: bug" and "Type: enhancement" for issue type.
What changes are included in this PR?
Use
type:
instead oflabels:
in issue templates.Are these changes tested?
Yes.
Are there any user-facing changes?
No.