Migrate parquet-variant-compute to Rust 2024

[mbrobbel]

Which issue does this PR close?

• Contribute to Test Rust 2024 Edition #6827

Rationale for this change

Splitting up #8227.

What changes are included in this PR?

Migrate parquet-variant-compute to Rust 2024

Are these changes tested?

CI

Are there any user-facing changes?

Yes

[alamb]

Looks great to me -- thank you @mbrobbel -- my only concern is that it will conflict with some of the outstanding PRs from @scovich , but I think given the changes it should be manageable

[mbrobbel]

Looks great to me -- thank you @mbrobbel -- my only concern is that it will conflict with some of the outstanding PRs from @scovich , but I think given the changes it should be manageable

We can maybe time this one so it doesn't conflict with open PRs? This one is easy to update/rebase.

[scovich]

I think it's a good time to update+merge this one; I'm tempted to use a let chain in a PR, which requires rust 2024

[alamb]

Let's get it refreshed and in!

[mbrobbel]

I think it's a good time to update+merge this one; I'm tempted to use a let chain in a PR, which requires rust 2024

We need to wait until we can bump the MSRV to 1.88 to get let chains: https://blog.rust-lang.org/2025/06/26/Rust-1.88.0/#let-chains

[alamb]

Thanks @mbrobbel -- bummer about the let chains. soon ™️

[scovich]

We need to wait until we can bump the MSRV to 1.88 to get let chains

Odd... I thought this same series of pull requests had also updated MSRV to 1.88? At least, I was no longer able to compile with older rust versions after pulling latest main and forcing to 1.85:

% cargo clippy --workspace --keep-going --tests
error: rustc 1.85.1 is not supported by the following package:
  [email protected] requires rustc 1.88

[scovich]

Ah, but it's "only" a dev dependency:

% cargo tree -i sysinfo        
sysinfo v0.37.1
[dev-dependencies]
├── parquet v56.2.0 (/Users/ryan.johnson/arrow-rs/parquet)
│   └── parquet_derive v56.2.0 (proc-macro) (/Users/ryan.johnson/arrow-rs/parquet_derive)
│       └── parquet_derive_test v56.2.0 (/Users/ryan.johnson/arrow-rs/parquet_derive_test)
└── parquet v56.2.0 (/Users/ryan.johnson/arrow-rs/parquet)
    └── parquet_derive_test v56.2.0 (/Users/ryan.johnson/arrow-rs/parquet_derive_test)

[scovich]

Aside: When compiling with 1.85, I get a lot of clippy warnings of the form:

warning: the following explicit lifetimes could be elided: 'a
    --> arrow-avro/src/writer/encoder.rs:1330:6
     |
1330 | impl<'a, P: ArrowPrimitiveType + IntervalToDurationParts> DurationEncoder<'a, P> {
     |      ^^                                                                   ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
1330 - impl<'a, P: ArrowPrimitiveType + IntervalToDurationParts> DurationEncoder<'a, P> {
1330 + impl<P: ArrowPrimitiveType + IntervalToDurationParts> DurationEncoder<'_, P> {
     |

... which seems very legit, I wonder why clippy 1.90 doesn't flag them?