Skip to content

Add variant_experimental feature to parquet crate #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/parquet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ jobs:
run: cargo check -p parquet --no-default-features --features flate2 --features flate2-rust_backened
- name: Check compilation --no-default-features --features flate2 --features flate2-zlib-rs
run: cargo check -p parquet --no-default-features --features flate2 --features flate2-zlib-rs

- name: Check compilation --no-default-features --features variant_experimental
run: cargo check -p parquet --no-default-features --features variant_experimental


# test the parquet crate builds against wasm32 in stable rust
wasm32-build:
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ parquet = { version = "56.0.0", path = "./parquet", default-features = false }
# These crates have not yet been released and thus do not use the workspace version
parquet-variant = { version = "0.1.0", path = "./parquet-variant" }
parquet-variant-json = { version = "0.1.0", path = "./parquet-variant-json" }
parquet-variant-compute = { version = "0.1.0", path = "./parquet-variant-json" }
parquet-variant-compute = { version = "0.1.0", path = "./parquet-variant-compute" }

chrono = { version = "0.4.40", default-features = false, features = ["clock"] }

Expand Down
6 changes: 6 additions & 0 deletions parquet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ arrow-data = { workspace = true, optional = true }
arrow-schema = { workspace = true, optional = true }
arrow-select = { workspace = true, optional = true }
arrow-ipc = { workspace = true, optional = true }
parquet-variant = { workspace = true, optional = true }
parquet-variant-json = { workspace = true, optional = true }
parquet-variant-compute = { workspace = true, optional = true }

object_store = { version = "0.12.0", default-features = false, optional = true }

bytes = { version = "1.1", default-features = false, features = ["std"] }
Expand Down Expand Up @@ -123,6 +127,8 @@ encryption = ["dep:ring"]
# Explicitely enabling rust_backend and zlib-rs features for flate2
flate2-rust_backened = ["flate2/rust_backend"]
flate2-zlib-rs = ["flate2/zlib-rs"]
# Enable parquet variant support
variant_experimental = ["parquet-variant", "parquet-variant-json", "parquet-variant-compute"]


[[example]]
Expand Down
2 changes: 2 additions & 0 deletions parquet/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,11 @@ The `parquet` crate provides the following features which may be enabled in your
- `experimental` - Experimental APIs which may change, even between minor releases
- `simdutf8` (default) - Use the [`simdutf8`] crate for SIMD-accelerated UTF-8 validation
- `encryption` - support for reading / writing encrypted Parquet files
- `variant_experimental` - ⚠️ Experimental [Parquet Variant] support, which may change, even between minor releases.

[`arrow`]: https://crates.io/crates/arrow
[`simdutf8`]: https://crates.io/crates/simdutf8
[parquet variant]: https://github.com/apache/parquet-format/blob/master/VariantEncoding.md

## Parquet Feature Status

Expand Down
11 changes: 11 additions & 0 deletions parquet/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,14 @@
//! [`ParquetRecordBatchStreamBuilder`]: arrow::async_reader::ParquetRecordBatchStreamBuilder
//! [`ParquetObjectReader`]: arrow::async_reader::ParquetObjectReader
//!
//! ## Variant Logical Type (`variant_experimental` feature)
//!
//! The [`variant`] module supports reading and writing Parquet files
//! with the [Variant Binary Encoding] logical type, which can represent
//! semi-structured data such as JSON efficiently.
//!
//! [Variant Binary Encoding]: https://github.com/apache/parquet-format/blob/master/VariantEncoding.md
//!
//! ## Read/Write Parquet Directly
//!
//! Workloads needing finer-grained control, or to avoid a dependence on arrow,
Expand Down Expand Up @@ -179,3 +187,6 @@ pub mod record;
pub mod schema;

pub mod thrift;

#[cfg(feature = "variant_experimental")]
pub mod variant;
111 changes: 111 additions & 0 deletions parquet/src/variant.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! ⚠️ Experimental Support for reading and writing [`Variant`]s to / from Parquet files ⚠️
//!
//! This is a 🚧 Work In Progress
//!
//! Note: Requires the `variant` feature of the `parquet` crate to be enabled.
//!
//! # Features
//! * [`Variant`] represents variant value, which can be an object, list, or primitive.
//! * [`VariantBuilder`] for building `Variant` values.
//! * [`VariantArray`] for representing a column of Variant values.
//! * [`compute`] module with functions for manipulating Variants, such as
//! [`variant_get`] to extracting a value by path and functions to convert
//! between `Variant` and JSON.
//!
//! [Variant Logical Type]: Variant
//! [`VariantArray`]: compute::VariantArray
//! [`variant_get`]: compute::variant_get
//!
//! # Example: Writing a Parquet file with Variant column
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being able to write this example is the largest rationale in my mind for the feature flag in the parquet crate

//! ```rust
//! # use parquet::variant::compute::{VariantArray, VariantArrayBuilder};
//! # use parquet::variant::VariantBuilderExt;
//! # use std::sync::Arc;
//! # use arrow_array::{ArrayRef, RecordBatch};
//! # use parquet::arrow::ArrowWriter;
//! # fn main() -> Result<(), parquet::errors::ParquetError> {
//! // Use the VariantArrayBuilder to build a VariantArray
//! let mut builder = VariantArrayBuilder::new(3);
//! // row 1: {"name": "Alice"}
//! let mut variant_builder = builder.variant_builder();
//! variant_builder.new_object().with_field("name", "Alice").finish()?;
//! variant_builder.finish();
//! let array = builder.build();
//!
//! // TODO support writing VariantArray directly
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will file a follow on ticket for this problem

//! // at the moment it panics when trying to downcast to a struct array
//! // let array: ArrayRef = Arc::new(array);
//! let array: ArrayRef = Arc::new(array.into_inner());
//!
//! // create a RecordBatch with the VariantArray
//! let batch = RecordBatch::try_from_iter(vec![("data", array)])?;
//!
//! // write the RecordBatch to a Parquet file
//! let file = std::fs::File::create("variant.parquet")?;
//! let mut writer = ArrowWriter::try_new(file, batch.schema(), None)?;
//! writer.write(&batch)?;
//! writer.close()?;
//!
//! # Ok(())
//! # }
//! ```
//!
//! # Example: Writing JSON with a Parquet file with Variant column
//! ```rust
//! # use std::sync::Arc;
//! # use arrow_array::{ArrayRef, RecordBatch, StringArray};
//! # use parquet::variant::compute::batch_json_string_to_variant;
//! # use parquet::variant::compute::VariantArray;
//! # use parquet::arrow::ArrowWriter;
//! # fn main() -> Result<(), parquet::errors::ParquetError> {
//! // Create an array of JSON strings, simulating a column of JSON data
//! // TODO use StringViewArray when available
//! let input_array = StringArray::from(vec![
//! Some(r#"{"name": "Alice", "age": 30}"#),
//! Some(r#"{"name": "Bob", "age": 25, "address": {"city": "New York"}}"#),
//! None,
//! Some("{}"),
//! ]);
//! let input_array: ArrayRef = Arc::new(input_array);
//!
//! // Convert the JSON strings to a VariantArray
//! let array: VariantArray = batch_json_string_to_variant(&input_array)?;
//!
//! // TODO support writing VariantArray directly
//! // at the moment it panics when trying to downcast to a struct array
//! // let array: ArrayRef = Arc::new(array);
//! let array: ArrayRef = Arc::new(array.into_inner());
//!
//! // create a RecordBatch with the VariantArray
//! let batch = RecordBatch::try_from_iter(vec![("data", array)])?;
//!
//! // write the RecordBatch to a Parquet file
//! let file = std::fs::File::create("variant-json.parquet")?;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of neat to see the data written. I looked at the resulting file using datafusion-cli and it looks like like this (note it does not have the parquet logical annotation on it)

> select * from 'parquet/variant-json.parquet';
+-----------------------------------------------------------------------------------------------------------------------------------+
| data                                                                                                                              |
+-----------------------------------------------------------------------------------------------------------------------------------+
| {metadata: 11020003076167656e616d65, value: 020200010002080c1e15416c696365}                                                       |
| {metadata: 010400040b0e1263697479616464726573736167656e616d65, value: 0203010203000e10140201000009214e657720596f726b0c190d426f62} |
| {metadata: 010000, value: 020000}                                                                                                 |
| {metadata: 010000, value: 020000}                                                                                                 |
+-----------------------------------------------------------------------------------------------------------------------------------+
4 row(s) fetched.
Elapsed 0.003 seconds.

//! let mut writer = ArrowWriter::try_new(file, batch.schema(), None)?;
//! writer.write(&batch)?;
//! writer.close()?;
//! # Ok(())
//! # }
//! ```
//!
//! # Example: Reading a Parquet file with Variant column
//! (TODO: add example)
pub use parquet_variant::*;
pub use parquet_variant_compute as compute;
Loading