Skip to content

Conversation

Nagai-Ryo-33
Copy link

@Nagai-Ryo-33 Nagai-Ryo-33 commented Jun 10, 2025

This PR introduces a new helper class for constructing Cloud Run Job Execution Links and integrates it into the existing Cloud Run operators in the Google Cloud provider for Airflow. The most important changes
include the addition of the CloudRunJobExecutionLink class, its integration into the CloudRunExecuteJobOperator, and the necessary imports and configurations.

New feature addition:

  • Added CLOUD_RUN_JOB_EXECUTION_LINK constant to construct URLs for Cloud Run Job Execution Links in airflow/providers/google/cloud/links/cloud_run.py
  • Created CloudRunJobExecutionLink class to handle the construction and persistence of Cloud Run Job Execution Links in airflow/providers/google/cloud/links/cloud_run.py

Integration into existing operators:

  • Imported CloudRunJobExecutionLink in airflow/providers/google/cloud/operators/cloud_run.py to make it available for use in Cloud Run operators
  • Updated operator_extra_links in CloudRunExecuteJobOperator to include CloudRunJobExecutionLink in airflow/providers/google/cloud/operators/cloud_run.py
  • Added logic to persist Cloud Run Job Execution Links in the execute method of CloudRunExecuteJobOperator in airflow/providers/google/cloud/operators/cloud_run.py

Configuration update:

  • Added CloudRunJobExecutionLink to the extra-links section in airflow/providers/google/provider.yaml to ensure it is recognized as an extra link

Screenshot:
The new "Cloud Run Job Execution" link appears in the Extra Links section of the task details page, alongside the existing "Cloud Run Job Logging" link.

スクリーンショット 2025-06-10 18 17 20

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 10, 2025
Copy link

boring-cyborg bot commented Jun 10, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@Nagai-Ryo-33 Nagai-Ryo-33 force-pushed the feature/add_cloud_run_job_detail_link branch from d27309a to 0b61f0d Compare June 10, 2025 02:59
@vatsrahul1001
Copy link
Contributor

@Nagai-Ryo-33 can we add some test for these?

@VladaZakharova
Copy link
Contributor

Hi there!
Thank you for the changes
There is a PR #51576 with changing the way we create links in google-provider, so I think you will need to rebase and change the links in your PR after our links refactoring will be merged.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 30, 2025
@github-actions github-actions bot closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants