-
Notifications
You must be signed in to change notification settings - Fork 403
scroll button added #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
scroll button added #1289
Conversation
|
The preview video was attached incorrectly. |
|
|
||
| <!-- Scroll to Top Button --> | ||
| <button id="scrollToTopBtn">▲</button> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think this code should be added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay , can i add new section for this button ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it would be best to implement it in a way similar to "Suggest a change on this page" button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @choo121600 i have added new section for the button . please review it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the scrollToTop button belongs in landing-pages/site/layouts/partials/suggest-change.html.
since they serve different functions.
031c4a1 to
8c84a3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still unnecessary changes(License, .. etc)
And please follow the design consistency.
|
|
||
| <!-- Scroll to Top Button --> | ||
| <button id="scrollToTopBtn">▲</button> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the scrollToTop button belongs in landing-pages/site/layouts/partials/suggest-change.html.
since they serve different functions.
Removed the scroll to top button from the suggest change partial.
Feature: Add Scroll-to-Top Button (Fixes #1279)
Description
This PR introduces a Scroll-to-Top button to improve page navigation on long content pages.
The button becomes visible once the user scrolls past a certain point and allows them to return to the top smoothly with a single click.
Why This Is Useful
Enhances user experience and accessibility
Reduces manual scrolling effort
Improves navigation especially on long or content-heavy pages
Implementation Details
Button remains hidden initially and appears after scrolling beyond a defined threshold
Smooth scrolling animation added for seamless experience
Positioned unobtrusively at the bottom-right corner
Styled to match the existing UI theme
Testing
Verified that button visibility toggles correctly on scroll
Confirmed smooth scroll behavior on click
Tested responsiveness across different screen sizes and devices
Checked compatibility across major browsers
Preview (video)
https://github.com/user-attachments/assets/d247f22f-f72e-4e10-8118-cb79df0397f8
Here is the video of button working.