-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use of GitHub Actions, and enable dependabot #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I also integrated GitHub Action in the PRs. |
00923e7 to
9b6fda3
Compare
|
I don’t think we should remove the unit test retry. @cshannon pointed that out as a good solution to get past some flaky tests and tests that fail when concurrent builds are running |
|
@mattrpav ok I readd it. I will also use a different strategy for tests to use different jdk. |
8b60aef to
376e097
Compare
|
FYI, I enabled again Jenkins on PR. I will disable it only when GitHub Action will be happy. |
8a6ba25 to
2d32e56
Compare
3fd6ef3 to
9b68ce6
Compare
|
Resuming this one 😄 |
9b68ce6 to
f168d56
Compare
|
Regarding the size of the matrix (2 ubuntu, 4 macos, 2 windows, with 3 different JDK versions), I propose:
The purpose is to speed up build/test on PRs, and keep the "full pass" on nightly (on demand). Imho, 80% of the matrix is useless (macos, all windows version, ...). |
|
Personnally, I think it's a great PR and it demonstrates what we can do and the benefits.
So overall, fully inline with you. |
jeanouii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR JB!
Few comments, FYI
I'm looking forward to see how quickly we can get results when other PRs are merged and how stable it will be.
This is overall a great investment for the future and will help us work better on deep functionalities like new JMS versions or Java 25 support
...re/src/test/java/org/apache/activemq/store/kahadb/JournalCorruptionEofIndexRecoveryTest.java
Outdated
Show resolved
Hide resolved
Keep a backup of Jenkinsfile for now
Re-add -Dsurefire.rerunFailingTestsCount=3 option to tests
…cluding Sonar stage
e1f09c4 to
c6ddb5b
Compare
|
So close 3h28 as far as the HTTP module. |
Keep a backup of Jenkinsfile for now