Fixed issue with exception in server run method not being logged

server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java

@@ -75,6 +75,27 @@ public static interface ThriftServerSupplier {
     ServerAddress get() throws UnknownHostException;
   }
 
+  public static void startServer(AbstractServer server, Logger LOG) throws Exception {
+    try {
+      server.runServer();
+    } catch (Exception e) {
+      System.err
+          .println(server.getClass().getSimpleName() + " died, exception thrown from runServer.");
+      e.printStackTrace();
+      LOG.error("{} died, exception thrown from runServer.", server.getClass().getSimpleName(), e);
+      throw e;
+    } finally {
+      try {
+        server.close();
+      } catch (Exception e) {
+        System.err.println("Exception thrown while closing " + server.getClass().getSimpleName());
+        e.printStackTrace();
+        LOG.error("Exception thrown while closing {}", server.getClass().getSimpleName(), e);
+        throw e;
+      }
+    }
+  }
+
   private final MetricSource metricSource;
   private final ServerContext context;
   protected final String applicationName;

server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java

@@ -1063,9 +1063,7 @@ public void run() {
   }
 
   public static void main(String[] args) throws Exception {
-    try (Compactor compactor = new Compactor(new ConfigOpts(), args)) {
-      compactor.runServer();
-    }
+    AbstractServer.startServer(new Compactor(new ConfigOpts(), args), LOG);
   }
 
   @Override

server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java

@@ -110,9 +110,7 @@ public class SimpleGarbageCollector extends AbstractServer implements Iface {
   }
 
   public static void main(String[] args) throws Exception {
-    try (SimpleGarbageCollector gc = new SimpleGarbageCollector(new ConfigOpts(), args)) {
-      gc.runServer();
-    }
+    AbstractServer.startServer(new SimpleGarbageCollector(new ConfigOpts(), args), log);
   }
 
   /**

server/manager/src/main/java/org/apache/accumulo/manager/Manager.java

@@ -481,9 +481,7 @@ public ThreadPoolExecutor getTabletRefreshThreadPool() {
   }
 
   public static void main(String[] args) throws Exception {
-    try (Manager manager = new Manager(new ConfigOpts(), ServerContext::new, args)) {
-      manager.runServer();
-    }
+    AbstractServer.startServer(new Manager(new ConfigOpts(), ServerContext::new, args), log);
   }
 
   protected Manager(ConfigOpts opts, Function<SiteConfiguration,ServerContext> serverContextFactory,

server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java

@@ -117,9 +117,7 @@ public class Monitor extends AbstractServer implements Connection.Listener {
   private final long START_TIME;
 
   public static void main(String[] args) throws Exception {
-    try (Monitor monitor = new Monitor(new ConfigOpts(), args)) {
-      monitor.runServer();
-    }
+    AbstractServer.startServer(new Monitor(new ConfigOpts(), args), log);
   }
 
   Monitor(ConfigOpts opts, String[] args) {

server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java

@@ -1137,9 +1137,7 @@ public BlockCacheConfiguration getBlockCacheConfiguration(AccumuloConfiguration
   }
 
   public static void main(String[] args) throws Exception {
-    try (ScanServer tserver = new ScanServer(new ConfigOpts(), args)) {
-      tserver.runServer();
-    }
+    AbstractServer.startServer(new ScanServer(new ConfigOpts(), args), LOG);
   }
 
 }

server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java

@@ -214,9 +214,7 @@ public PausedCompactionMetrics getPausedCompactionMetrics() {
   private final ServerContext context;
 
   public static void main(String[] args) throws Exception {
-    try (TabletServer tserver = new TabletServer(new ConfigOpts(), ServerContext::new, args)) {
-      tserver.runServer();
-    }
+    AbstractServer.startServer(new TabletServer(new ConfigOpts(), ServerContext::new, args), log);
   }
 
   protected TabletServer(ConfigOpts opts,