init method to avoid leaking this reference in manager constructor
#5732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created an init method that sets timeKeeper and tserverSet after manager has been fully constructed so that an incomplete `this` referenced is not passed through those constructors. This init method should be called after every new Manager object has been created. Closes apache#5673
kevinrr888
reviewed
Jul 9, 2025
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
…r to changes to the BalanceManager so that the `this` keyword is passed through a set method rather than the constructor. Changed other calls to ManagerTime and LiveTServerSet to reflect those changes.
…cumulo-5673 # Conflicts: # server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
server/manager/src/main/java/org/apache/accumulo/manager/ManagerTime.java
Show resolved
Hide resolved
server/base/src/main/java/org/apache/accumulo/server/manager/LiveTServerSet.java
Outdated
Show resolved
Hide resolved
…rtListeningForTabletServerChanges method. Changes code that called the setCback() method.
keith-turner
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an init method that sets timeKeeper and tserverSet after manager has been fully constructed so that an incomplete
thisreference is not passed through those constructors. This init method should be called after every new Manager object has been created.Closes #5673