Replacing mocks of TabletId with TabletId.of()#5718
Merged
Conversation
kevinrr888
reviewed
Jul 7, 2025
kevinrr888
left a comment
kevinrr888
left a comment
Member
There was a problem hiding this comment.
Looks good. Could make this target 2.1 since that's where these TabletId.of() changes fell and this only effects this test in 2.1 and main
Using the TabletId.of() method created in PR apache#5678, replaced instances of TabletId mocks in ConstraintCheckerTest.java. Closes apache#5705
ibilley7
force-pushed
the
task/accumulo-5705
branch
from
60c2b69 to
65add0c
Compare
DomGarguilo
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the TabletId.of() method created in PR #5678, replaced instances of TabletId mocks in ConstraintCheckerTest.java.
Closes #5705