Preparing the modules before final package separation#10
Open
anujkumar93 wants to merge 7 commits intosplit_testsfrom
Open
Preparing the modules before final package separation#10anujkumar93 wants to merge 7 commits intosplit_testsfrom
anujkumar93 wants to merge 7 commits intosplit_testsfrom
Conversation
This was referenced Dec 3, 2018
added 6 commits
December 3, 2018 15:12
|
lgtm |
This was referenced Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jtratner
This PR handles getting the complete repo ready for its separation into individual packages of stor, stor_s3, stor_swift, stor_dx.
Background
This is a continuation of the story to split stor across 4 modules : stor, stor_dx, stor_swift, stor_s3. This is done to easy the dependencies that need to be installed to use a particular fact of stor, and to make it more modular. This PR is preceded by #9 for this story.
Changes
This PR handles changes in docs relevant to the split classes and handling of 'is_swift_path', 'is_dx_path', 'is_s3_path', etc in utils. They have been moved to their respective packages. The convert_swiftstack method in cli.py also has been changed to reflect a try catch block on import swiftpath.
Tested via:
The testing suite was run successfully. No new tests were added since no functionality changed.
TODOS