Feat/undo redo

[elijahthis]

Undo/Redo for Node Deletion

Fixes #370

New Keybindings (vim-like):

• u: Undo last deletion.
• ctrl+r: Redo last undone deletion.

Testing Performed

• Deleting and undoing single values.
• Deleting/Undoing entire objects and arrays.
• Verified that array indices ([0], [1], etc.) update correctly in both directions.
• Verified that trailing commas are added/removed correctly when undoing the deletion of the last element in a container.

[antonmedv]

Looks like this method does not uses any model fields. Lets move it to josnx package?

[antonmedv]

The logic on undo will be nice to put to jsonx package as well.

[antonmedv]

Implementation is nice, but lets move all model independent parts to nodes.

And lets add tests! JSON -> delete node -> assert JSON -> redo node -> assert JSON

[elijahthis]

thanks for the comments / review @antonmedv. really solid points.

on it!

[elijahthis]

hi @antonmedv
all done. just added testing. had to update .golden files as well to reflect changes to testdata 🫠

[antonmedv]

ctrl+r: Redo last undone deletion.

But do we really need redo?

[elijahthis]

But do we really need redo?

hmm.
well it's worth having in case a user spams the "undo" button. accidentally. Plus users familiar with vim might expect there to be a redo if there's an undo.

[elijahthis]

Plus since we already implemented Tombstone, the redo is a relatively straightforward implementation.

[antonmedv]

what about instead of key binding, use command :u

[elijahthis]

what about instead of key binding, use command :u

might feel slightly off for vim users. could work though. they'll just have to read the docs.

also, when you say command+u, do you mean cmd/alt+u for redo? or ctrl+u for redo?

[antonmedv]

I see. Ok, lets keep u.

Please rebase!

[elijahthis]

Please rebase!

Just rebased. No conflicts with master!

[elijahthis]

Hi @antonmedv any updates on this?