Skip to content

feat(codex): add plugin manifest#23

Merged
antonbabenko merged 4 commits into
antonbabenko:masterfrom
kirillmorozov:master
May 18, 2026
Merged

feat(codex): add plugin manifest#23
antonbabenko merged 4 commits into
antonbabenko:masterfrom
kirillmorozov:master

Conversation

@kirillmorozov
Copy link
Copy Markdown
Contributor

Pull Request

Description

Type of change:

  • New content (adding best practices, patterns, or guidance)
  • Fix (correcting outdated or incorrect information)
  • Refactor (reorganizing or improving clarity)
  • Documentation (README, CONTRIBUTING, etc.)
  • Testing framework improvement

Summary:

Add Codex plugin manifest to simplify installation process for OpenAI Codex agent.

Testing Evidence (REQUIRED)

I've been able to install this skill as a plugin from my fork using a method I've specified in README.md:

Screenshot 2026-04-28 at 22 07 39

Additional Context

I've also tried to add a marketplace manifest to this repo to be able to install this skill using

codex plugin marketplace add antonbabenko/terraform-skill

but currently it's not possible due to the way this repo is structured and openai/codex#17066.


For Maintainers

Review Checklist

  • Testing evidence is convincing (baseline → compliance improvement shown)
  • Standards compliance verified
  • Content is accurate and current
  • Token efficiency maintained
  • Quality standards met
  • No conflicts with existing content
  • CHANGELOG.md updated (if needed)

Merge Checklist

  • Squash commits with clear commit message
  • Update CHANGELOG.md if not done in PR
  • Consider if version bump needed
  • Tag if this completes a planned milestone

…DME block

The hand-set manifest version (1.8.0) would go stale immediately: this
repo's policy is a single CI-owned version source (SKILL.md frontmatter),
no hand-edited version numbers. Set it to the current 1.12.0 and wire
.codex-plugin/plugin.json into automated-release.yml so every release
syncs it alongside SKILL.md, with a validate.yml cross-check that fails
the PR on drift.

Drop the README block instructing users to hand-add a url-source entry
pinned to master in ~/.agents/plugins/marketplace.json: it is
unversioned and conflicts with the repo's single-marketplace setup
(README already warns that adding antonbabenko/terraform-skill as its
own marketplace clashes by name with agent-plugins). The manifest alone
enables the supported managed path via the antonbabenko/agent-plugins
Codex marketplace; replace the block with a pointer to that path.
@antonbabenko
Copy link
Copy Markdown
Owner

Pushed a commit on top of yours to get this mergeable - thanks for the contribution and the openai/codex#17066 link.

What changed and why:

  • Manifest version: it was hardcoded to 1.8.0; this repo keeps a single CI-owned version source (SKILL.md frontmatter) and never hand-edits version numbers, so it would have gone stale at the next release. Set it to the current 1.12.0 and wired .codex-plugin/plugin.json into automated-release.yml so it syncs on every release, with a validate.yml check that fails the PR on drift.
  • README block dropped: it told users to hand-add a url-source entry pinned to master in their personal ~/.agents/plugins/marketplace.json. That is unversioned and conflicts with the single-marketplace setup the README already documents (adding antonbabenko/terraform-skill as its own marketplace clashes by name with agent-plugins). Replaced it with a short pointer to the managed path: codex plugin marketplace add antonbabenko/agent-plugins then install terraform-skill.

The manifest itself is the useful part - it is what lets the existing agent-plugins Codex marketplace entry resolve this repo as a url-source plugin. Could you confirm codex plugin marketplace add antonbabenko/agent-plugins then installing terraform-skill works with the manifest in place? That is the flow we want to support.

- automated-release.yml: replace `[ -f ] && git add || true` with an
  explicit if block so a real `git add` failure is no longer masked
  under `bash -e`; absent-manifest case still skipped cleanly.
- automated-release.yml: anchor the manifest version line match to a
  2-space indent (top-level key only) so a nested "version" key can
  never be matched.
- validate.yml: the sync check now requires both versions to exist and
  be valid semver, not merely equal (equality alone passed when both
  were missing/empty).

Addresses independent GPT and Gemini review feedback on PR antonbabenko#23. Does not
fix the separate pre-existing release-tag staleness (tracked separately).
@antonbabenko antonbabenko merged commit cfbafe4 into antonbabenko:master May 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants