Fix custom variable check for use-package :custom blocks.#17
Merged
anticomputer merged 1 commit intomainfrom Feb 28, 2025
Merged
Fix custom variable check for use-package :custom blocks.#17anticomputer merged 1 commit intomainfrom
anticomputer merged 1 commit intomainfrom
Conversation
Related to: jwiegley/use-package#1002 Use-package :custom blocks end up as theme-value symbol properties. Since our code is forked from epg, we inherited its symbol property checks that don't account for use-package's theme-value property on :custom variables. This can introduce cache confusion and result in the incorrect binary being invoked on systems that contain e.g. both rage and age binaries due to program alist ordering. The user's custom value should always take precedent over any auto configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: jwiegley/use-package#1002
Use-package :custom blocks end up as theme-value symbol properties. Since our code is forked from epg, we inherited its symbol property checks that don't account for use-package's theme-value property on :custom variables.
This can introduce cache confusion and result in the incorrect binary being invoked on systems that contain e.g. both rage and age binaries due to program alist ordering.
The user's custom value should always take precedent over any auto configuration.