fix: resolve SINDI clang-tidy failures

[wxyucs]

Summary

• Resolve the five clang-tidy 15 errors introduced by c715b63d in src/algorithm/sindi/sindi.cpp.
• Use named validity predicates for macro-expanded bounds checks.
• Mark the immutable-window serializer static and use a transparent comparison functor.

Verification

• Focused clang-tidy 15 on all source files changed by the recent main commits: passed.
• cmake --build build-release --target sindi -j4: passed.
• SINDI unit tests: 26 test cases and 184,409 assertions passed.

Fixes: #2487

[vsag-bot]

/label S-ready-to-merge
/waiting-on maintainer
/request-review @jiaweizone
/request-review @inabao

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[vsag-bot]

Automated pull request review completed.

Review effort: low (23 changed lines across 2 files).

No actionable inline findings were found.
Review: #2477 (review)

[mergify]

Merge Protections

🟢 All 3 merge protections satisfied — ready to merge.

Show 3 satisfied protections

🟢 Require kind label

• label~=^kind/

🟢 Require version label

• label~=^version/

🟢 Require linked issue for feature/bug PRs

• body~=(?im)(?:^|[\s\-\*])(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s*:?\s+(?:#\d+|[\w.\-]+/[\w.\-]+#\d+|https?://github\.com/[\w.\-]+/[\w.\-]+/issues/\d+)

[gemini-code-assist]

Code Review

This pull request refactors several methods in the SINDI class to improve readability and code structure. Specifically, it extracts complex boolean expressions into descriptive local variables within Deserialize and deserialize_immutable_window. It also simplifies the template argument for std::greater_equal and changes serialize_immutable_window from a const member function to a static member function. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[wxyucs]

/version 1.1

[vsag-bot]

Automated inline review completed.

Review effort: low (23 changed lines across 2 files).
No actionable inline findings were found.

Reviewed commit f09f122.

[LHT129]

LGTM

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request