feat: add support for bun catalog #192
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use both bun and taze, and I really need this feature |
Duckapple
reviewed
Aug 28, 2025
| return loadPnpmWorkspace(relative, options, shouldUpdate) | ||
| if (relative === 'package.json' && options.cwd) { | ||
| // Check if this is a bun workspace root by looking for bun.lockb | ||
| const bunLockPath = join(options.cwd, 'bun.lockb') |
There was a problem hiding this comment.
Bun has transitioned to using a non-binary lockfile by default, while maintaining support for the binary format. IMO, we should be detecting them both, maybe by iterating over an array like:
let isBunProject = false;
for (const lockfile of ['bun.lockb', 'bun.lock']) {
const bunLockPath = join(options.cwd, 'bun.lockb');
isBunProject ||= existsSync(bunLockPath);
}
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add support for bun catalog
Linked Issues
#190