feat: allow download missing frameworks zip from bag #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for icones ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
userquin
changed the title
userquin
commented
Jul 1, 2025
src/utils/svg/helpers.ts
Outdated
| import { prettierCode } from './prettier' | ||
|
|
||
| export type PackType = 'svg' | 'tsx' | 'jsx' | 'vue' | 'json' | ||
| export type PackType = 'svg' | 'tsx' | 'jsx' | 'vue' | 'vue-tsc' | 'solid' | 'qwik' | 'svelte' | 'astro' | 'react-native' | 'json' |
antfu
reviewed
Jul 1, 2025
antfu
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added missing frameworks to the Download Zip option in the Bag, using the same list in the IconDetail.vue component excluding PNG format.
Applied same logic for file extension used in download function in the web worker.
Linked Issues
resolves #370
Additional context