feat: use ESM svg-packer with Vite #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for icones ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced May 26, 2025
antfu
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before merging check #365 , maybe you also want a web worker.
This PR using ESM version of
svg-packerwith Vite, replacing alsojszipwithclient-zip, including:We need to review
electron, no idea how to test it and do some check about generated zips, all seems to be fine but exporting full collections getting huge differences, for example exporting mdi, current version ~3MB while the new version ~14MB.#363 moved here (branch here)
supersedes #363
Linked Issues
resolves #362
Additional context
We should add a web worker or reuse the service worker to generate the zip files.
The build result with 2MB less of js code 😍 :