Skip to content

fix: SubPart commit modified to work when updating an existing subpart #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

echambla
Copy link
Collaborator

@echambla echambla commented Jul 11, 2025

Description

Create a sub part, in a project root part.
Commit.
Modify its axis system.
Commit.
The axis system of the subpart was not modified on the server side.

Issue linked

#639

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@echambla echambla self-assigned this Jul 11, 2025
@github-actions github-actions bot added the bug Something isn't working label Jul 11, 2025
@echambla
Copy link
Collaborator Author

Still need to add unit tests on this.
Not ready for merge

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (689d751) to head (bc874f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   88.90%   88.91%           
=======================================
  Files          39       39           
  Lines        5616     5618    +2     
=======================================
+ Hits         4993     4995    +2     
  Misses        623      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants