test: Add test to check PyFluent launched PyConsole by default.

[prmukherj]

Add test to check PyFluent launched PyConsole by default.

[hpohekar]

@prmukherj

This is incorrect behaviour. We need to resolve this. The issue description already states that we must add unit test with fix.

We just need to update the following condition and I can confirm that it resolves this issue.

from ansys.fluent.core import config

if (
            (fluent_version and fluent_version >= FluentVersion.v251) or config.fluent_root
            and self.argvals["py"] is None
        ):
            self.argvals["py"] = True

https://github.com/ansys/pyfluent/blob/main/src/ansys/fluent/core/launcher/standalone_launcher.py#L207

cc: @seanpearsonuk @mkundu1

[prmukherj]

@prmukherj

This is incorrect behaviour. We need to resolve this. The issue description already states that we must add unit test with fix.

We just need to update the following condition and I can confirm that it resolves this issue.

from ansys.fluent.core import config

if (
            (fluent_version and fluent_version >= FluentVersion.v251) or config.fluent_root
            and self.argvals["py"] is None
        ):
            self.argvals["py"] = True

https://github.com/ansys/pyfluent/blob/main/src/ansys/fluent/core/launcher/standalone_launcher.py#L207

cc: @seanpearsonuk @mkundu1

I don't think it makes sense. I think the earlier behaviour was more correct. What if user sets fluent_root to 22R2?

[prmukherj]

@prmukherj
This is incorrect behaviour. We need to resolve this. The issue description already states that we must add unit test with fix.
We just need to update the following condition and I can confirm that it resolves this issue.

from ansys.fluent.core import config

if (
            (fluent_version and fluent_version >= FluentVersion.v251) or config.fluent_root
            and self.argvals["py"] is None
        ):
            self.argvals["py"] = True

https://github.com/ansys/pyfluent/blob/main/src/ansys/fluent/core/launcher/standalone_launcher.py#L207
cc: @seanpearsonuk @mkundu1

I don't think it makes sense. I think the earlier behaviour was more correct. What if user sets fluent_root to 22R2?

Moreover, if we want to make this change, '_get_standalone_launch_fluent_version' is the correct place to do so I believe.

[mkundu1]

@prmukherj If we directly use StandaloneLauncher class + dry_run, will we able to run it in github?

[prmukherj]

@prmukherj If we directly use StandaloneLauncher class + dry_run, will we able to run it in github?

yes, should be possible.