Skip to content

build(deps): update pandas requirement from <2.3,>=1.1.0 to >=1.1.0,<2.4 #4229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/4229.dependencies.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
update pandas requirement from <2.3,>=1.1.0 to >=1.1.0,<2.4
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies = [
"grpcio-status>=1.26.0",
"nltk>=3.9.1",
"numpy>=1.14.0,<3.0.0",
"pandas>=1.1.0,<2.3",
"pandas>=1.1.0,<2.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prmukherj @hpohekar @mkundu1

Do we really need to maintain a rolling 2.x limit for pandas?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanpearsonuk I think we can change it to "pandas>=1.1.0"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prmukherj @hpohekar @mkundu1 I was thinking we could still have an upper limit, but something broad like <3 to guard against potential breaking changes in a future major version. But I am still open to keeping the present policy in place if it is well-founded.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can change it to "pandas>=1.1.0,<3" to avoid frequent updates.

"pyansys-tools-report>=0.8.1",
"pyyaml>=6.0",
]
Expand Down