-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Set string settings with allowed values via string constants #4190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+94
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mkundu1, existing tests suggest that something has gone wrong. |
Validation against all possible allowed values during set_state is now possible in the client side, will add it. |
That's great! Thank you. |
seanpearsonuk
approved these changes
Jun 19, 2025
hpohekar
approved these changes
Jun 19, 2025
b79d1b3
to
58bf0e1
Compare
prmukherj
approved these changes
Jul 2, 2025
58bf0e1
to
18ca6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enumerated values are exposed as constant attributes of the instance. Please see the unittest for usage.
There is already an attribute
allowed-values-with-display-text
in settings API to fetch all possible allowed values which has been added to the static-info (Fluent PR 599447).Below is the fragment of generated class:
TODO: doc update