REFACTOR: design_types.py #1333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
grpc-transition
For more information, see https://pre-commit.ci
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
===========================================
- Coverage 76.17% 58.07% -18.11%
===========================================
Files 162 217 +55
Lines 23786 35647 +11861
===========================================
+ Hits 18119 20701 +2582
- Misses 5667 14946 +9279 🚀 New features to boost your workflow:
|
SMoraisAnsys
reviewed
Jul 6, 2025
| @@ -34,7 +38,7 @@ def Edb( | |||
| technology_file=None, | |||
| grpc=False, | |||
| control_file=None, | |||
| ): | |||
| ) -> EdbDotnet: | |||
There was a problem hiding this comment.
This isnt true as EDBGrpc can also be returned. Please update the type hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes available methods/properties show up in IDE