Skip to content

CHORE: Ansys version warning vs grpc #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 80 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
00250e4
grpc transition PR#1005 tracker
svandenb-dev Mar 25, 2025
534a4fb
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 1, 2025
08ee4f6
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 1, 2025
80e56ea
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 2, 2025
ed9a6d8
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 2, 2025
10bda00
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 2, 2025
647b426
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 2, 2025
3d75f93
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 2, 2025
89e41a2
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 3, 2025
3bdbbb1
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 4, 2025
6d9b264
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 9, 2025
580f542
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 10, 2025
cd224b0
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 10, 2025
b5d4dbb
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 10, 2025
a1eb46d
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 10, 2025
00f5cae
grpc test_01a_setups_frequency_sweeps
svandenb-dev Apr 11, 2025
b8b8171
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 11, 2025
49deb6c
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 14, 2025
daa31dd
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 15, 2025
ae76f6e
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 16, 2025
8f70584
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 16, 2025
1c1be82
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 17, 2025
afaac7b
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 17, 2025
9335773
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 18, 2025
11989f8
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 22, 2025
a6f2472
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 22, 2025
c5719ac
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 22, 2025
873f21d
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 22, 2025
b430d3d
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 23, 2025
a9b7abf
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 23, 2025
f3fb121
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 25, 2025
8fcdfc6
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 25, 2025
0d3635f
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 25, 2025
37ca625
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 28, 2025
c009c60
Merge remote-tracking branch 'origin/main'
svandenb-dev Apr 30, 2025
8bcfb88
Merge remote-tracking branch 'origin/main'
svandenb-dev May 2, 2025
557f752
Merge remote-tracking branch 'origin/main'
svandenb-dev May 2, 2025
3c692e4
Merge remote-tracking branch 'origin/main'
svandenb-dev May 5, 2025
c75e276
Merge remote-tracking branch 'origin/main'
svandenb-dev May 5, 2025
28d6680
grpc test fix
svandenb-dev May 5, 2025
5577313
Merge remote-tracking branch 'origin/main'
svandenb-dev May 5, 2025
659b038
Merge remote-tracking branch 'origin/main'
svandenb-dev May 5, 2025
94407a2
Merge remote-tracking branch 'origin/main'
svandenb-dev May 6, 2025
c4a17bb
Merge remote-tracking branch 'origin/main'
svandenb-dev May 6, 2025
32bbe52
Merge remote-tracking branch 'origin/main'
svandenb-dev May 6, 2025
0f250a0
Merge remote-tracking branch 'origin/main'
svandenb-dev May 6, 2025
ae2043e
Merge remote-tracking branch 'origin/main'
svandenb-dev May 7, 2025
4021a4a
Merge remote-tracking branch 'origin/main'
svandenb-dev May 7, 2025
40f583c
Merge remote-tracking branch 'origin/main'
svandenb-dev May 9, 2025
c0ebe6a
Merge remote-tracking branch 'origin/main'
svandenb-dev May 9, 2025
4c2a0f0
Merge remote-tracking branch 'origin/main'
svandenb-dev May 19, 2025
c57005d
Merge remote-tracking branch 'origin/main'
svandenb-dev May 19, 2025
d1303aa
Merge remote-tracking branch 'origin/main'
svandenb-dev May 19, 2025
bfa109d
Merge remote-tracking branch 'origin/main'
svandenb-dev May 21, 2025
0d47568
Merge remote-tracking branch 'origin/main'
svandenb-dev May 21, 2025
4ddf579
Merge remote-tracking branch 'origin/main'
svandenb-dev May 21, 2025
3ff21cc
Merge remote-tracking branch 'origin/main'
svandenb-dev May 21, 2025
f53930f
Merge remote-tracking branch 'origin/main'
svandenb-dev May 22, 2025
d02a496
Merge remote-tracking branch 'origin/main'
svandenb-dev May 23, 2025
1178822
Merge remote-tracking branch 'origin/main'
svandenb-dev May 25, 2025
8a13daf
Merge remote-tracking branch 'origin/main'
svandenb-dev May 25, 2025
ed7780b
Merge remote-tracking branch 'origin/main'
svandenb-dev May 26, 2025
2d895c2
Merge remote-tracking branch 'origin/main'
svandenb-dev May 27, 2025
0f5202b
Merge remote-tracking branch 'origin/main'
svandenb-dev May 27, 2025
d137f06
some deprecation
svandenb-dev May 27, 2025
487c749
components
svandenb-dev May 27, 2025
fa081d3
definitions
svandenb-dev May 27, 2025
cc14ca5
hfss
svandenb-dev May 27, 2025
0ba9d00
layout validation
svandenb-dev May 27, 2025
70db3ba
Merge remote-tracking branch 'origin/main'
svandenb-dev Jun 2, 2025
66a0476
Merge remote-tracking branch 'origin/main'
svandenb-dev Jun 4, 2025
9d0859f
components returned typing
svandenb-dev Jun 4, 2025
a0fef75
Merge remote-tracking branch 'origin/main'
svandenb-dev Jun 9, 2025
6e82b25
Merge remote-tracking branch 'origin/main'
svandenb-dev Jun 11, 2025
b8b86b9
Merge remote-tracking branch 'origin/main'
svandenb-dev Jun 12, 2025
494074f
Merge remote-tracking branch 'origin/main'
svandenb-dev Jun 17, 2025
fb359a5
grpc warning messages
svandenb-dev Jun 17, 2025
46a0c45
grpc warning messages
svandenb-dev Jun 17, 2025
310730d
grpc warning messages
svandenb-dev Jun 17, 2025
315c7bf
warnings
svandenb-dev Jul 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/pyedb/dotnet/edb.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@
from pyedb.modeler.geometry_operators import GeometryOperators
from pyedb.workflow import Workflow

GRPC_WARNING = (
"Your ANSYS AEDT version is eligible to gRPC version, "
"You might consider switching to that version for better user experience."
"For more information please check this link: https://edb.docs.pyansys.com/version/dev/grpc_api/index.html"
)


class Edb(Database):
"""Provides the EDB application interface.
Expand Down Expand Up @@ -199,6 +205,8 @@ def __init__(
edbpath = str(edbpath)

edbversion = get_string_version(edbversion)
if float(edbversion) >= 2025.2:
warnings.warn(GRPC_WARNING, UserWarning)
self._clean_variables()
Database.__init__(self, edbversion=edbversion, student_version=student_version)
self.standalone = True
Expand Down
13 changes: 13 additions & 0 deletions src/pyedb/generic/design_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
import warnings

GRPC_WARNING = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you import the other GRPC warning instead of duplicating ?

"Your ANSYS AEDT version is eligible to gRPC version, "
"You might consider switching to that version for better user experience."
"For more information please check this link: https://edb.docs.pyansys.com/version/dev/grpc_api/index.html"
)


# lazy imports
Expand Down Expand Up @@ -114,6 +121,12 @@ def Edb(
"""

# Use EDB legacy (default choice)
if float(edbversion) >= 2025.2:
if not grpc:
warnings.warn(GRPC_WARNING, UserWarning)
else:
if grpc:
raise f"gRPC flag was enabled however your ANSYS AEDT version {edbversion} is not compatible"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise f"gRPC flag was enabled however your ANSYS AEDT version {edbversion} is not compatible"
raise ValueError(f"gRPC flag was enabled however your ANSYS AEDT version {edbversion} is not compatible")

if grpc:
from pyedb.grpc.edb import Edb as app
else:
Expand Down
Loading