-
Notifications
You must be signed in to change notification settings - Fork 13
CHORE: Ansys version warning vs grpc #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
svandenb-dev
wants to merge
80
commits into
main
Choose a base branch
from
ansys-version-warning-vs-grpc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−0
Open
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
00250e4
grpc transition PR#1005 tracker
svandenb-dev 534a4fb
Merge remote-tracking branch 'origin/main'
svandenb-dev 08ee4f6
Merge remote-tracking branch 'origin/main'
svandenb-dev 80e56ea
Merge remote-tracking branch 'origin/main'
svandenb-dev ed9a6d8
Merge remote-tracking branch 'origin/main'
svandenb-dev 10bda00
Merge remote-tracking branch 'origin/main'
svandenb-dev 647b426
Merge remote-tracking branch 'origin/main'
svandenb-dev 3d75f93
Merge remote-tracking branch 'origin/main'
svandenb-dev 89e41a2
Merge remote-tracking branch 'origin/main'
svandenb-dev 3bdbbb1
Merge remote-tracking branch 'origin/main'
svandenb-dev 6d9b264
Merge remote-tracking branch 'origin/main'
svandenb-dev 580f542
Merge remote-tracking branch 'origin/main'
svandenb-dev cd224b0
Merge remote-tracking branch 'origin/main'
svandenb-dev b5d4dbb
Merge remote-tracking branch 'origin/main'
svandenb-dev a1eb46d
Merge remote-tracking branch 'origin/main'
svandenb-dev 00f5cae
grpc test_01a_setups_frequency_sweeps
svandenb-dev b8b8171
Merge remote-tracking branch 'origin/main'
svandenb-dev 49deb6c
Merge remote-tracking branch 'origin/main'
svandenb-dev daa31dd
Merge remote-tracking branch 'origin/main'
svandenb-dev ae76f6e
Merge remote-tracking branch 'origin/main'
svandenb-dev 8f70584
Merge remote-tracking branch 'origin/main'
svandenb-dev 1c1be82
Merge remote-tracking branch 'origin/main'
svandenb-dev afaac7b
Merge remote-tracking branch 'origin/main'
svandenb-dev 9335773
Merge remote-tracking branch 'origin/main'
svandenb-dev 11989f8
Merge remote-tracking branch 'origin/main'
svandenb-dev a6f2472
Merge remote-tracking branch 'origin/main'
svandenb-dev c5719ac
Merge remote-tracking branch 'origin/main'
svandenb-dev 873f21d
Merge remote-tracking branch 'origin/main'
svandenb-dev b430d3d
Merge remote-tracking branch 'origin/main'
svandenb-dev a9b7abf
Merge remote-tracking branch 'origin/main'
svandenb-dev f3fb121
Merge remote-tracking branch 'origin/main'
svandenb-dev 8fcdfc6
Merge remote-tracking branch 'origin/main'
svandenb-dev 0d3635f
Merge remote-tracking branch 'origin/main'
svandenb-dev 37ca625
Merge remote-tracking branch 'origin/main'
svandenb-dev c009c60
Merge remote-tracking branch 'origin/main'
svandenb-dev 8bcfb88
Merge remote-tracking branch 'origin/main'
svandenb-dev 557f752
Merge remote-tracking branch 'origin/main'
svandenb-dev 3c692e4
Merge remote-tracking branch 'origin/main'
svandenb-dev c75e276
Merge remote-tracking branch 'origin/main'
svandenb-dev 28d6680
grpc test fix
svandenb-dev 5577313
Merge remote-tracking branch 'origin/main'
svandenb-dev 659b038
Merge remote-tracking branch 'origin/main'
svandenb-dev 94407a2
Merge remote-tracking branch 'origin/main'
svandenb-dev c4a17bb
Merge remote-tracking branch 'origin/main'
svandenb-dev 32bbe52
Merge remote-tracking branch 'origin/main'
svandenb-dev 0f250a0
Merge remote-tracking branch 'origin/main'
svandenb-dev ae2043e
Merge remote-tracking branch 'origin/main'
svandenb-dev 4021a4a
Merge remote-tracking branch 'origin/main'
svandenb-dev 40f583c
Merge remote-tracking branch 'origin/main'
svandenb-dev c0ebe6a
Merge remote-tracking branch 'origin/main'
svandenb-dev 4c2a0f0
Merge remote-tracking branch 'origin/main'
svandenb-dev c57005d
Merge remote-tracking branch 'origin/main'
svandenb-dev d1303aa
Merge remote-tracking branch 'origin/main'
svandenb-dev bfa109d
Merge remote-tracking branch 'origin/main'
svandenb-dev 0d47568
Merge remote-tracking branch 'origin/main'
svandenb-dev 4ddf579
Merge remote-tracking branch 'origin/main'
svandenb-dev 3ff21cc
Merge remote-tracking branch 'origin/main'
svandenb-dev f53930f
Merge remote-tracking branch 'origin/main'
svandenb-dev d02a496
Merge remote-tracking branch 'origin/main'
svandenb-dev 1178822
Merge remote-tracking branch 'origin/main'
svandenb-dev 8a13daf
Merge remote-tracking branch 'origin/main'
svandenb-dev ed7780b
Merge remote-tracking branch 'origin/main'
svandenb-dev 2d895c2
Merge remote-tracking branch 'origin/main'
svandenb-dev 0f5202b
Merge remote-tracking branch 'origin/main'
svandenb-dev d137f06
some deprecation
svandenb-dev 487c749
components
svandenb-dev fa081d3
definitions
svandenb-dev cc14ca5
hfss
svandenb-dev 0ba9d00
layout validation
svandenb-dev 70db3ba
Merge remote-tracking branch 'origin/main'
svandenb-dev 66a0476
Merge remote-tracking branch 'origin/main'
svandenb-dev 9d0859f
components returned typing
svandenb-dev a0fef75
Merge remote-tracking branch 'origin/main'
svandenb-dev 6e82b25
Merge remote-tracking branch 'origin/main'
svandenb-dev b8b86b9
Merge remote-tracking branch 'origin/main'
svandenb-dev 494074f
Merge remote-tracking branch 'origin/main'
svandenb-dev fb359a5
grpc warning messages
svandenb-dev 46a0c45
grpc warning messages
svandenb-dev 310730d
grpc warning messages
svandenb-dev 315c7bf
warnings
svandenb-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -19,6 +19,13 @@ | |||||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||||||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||||||
# SOFTWARE. | ||||||
import warnings | ||||||
|
||||||
GRPC_WARNING = ( | ||||||
"Your ANSYS AEDT version is eligible to gRPC version, " | ||||||
"You might consider switching to that version for better user experience." | ||||||
"For more information please check this link: https://edb.docs.pyansys.com/version/dev/grpc_api/index.html" | ||||||
) | ||||||
|
||||||
|
||||||
# lazy imports | ||||||
|
@@ -114,6 +121,12 @@ def Edb( | |||||
""" | ||||||
|
||||||
# Use EDB legacy (default choice) | ||||||
if float(edbversion) >= 2025.2: | ||||||
if not grpc: | ||||||
warnings.warn(GRPC_WARNING, UserWarning) | ||||||
else: | ||||||
if grpc: | ||||||
raise f"gRPC flag was enabled however your ANSYS AEDT version {edbversion} is not compatible" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
if grpc: | ||||||
from pyedb.grpc.edb import Edb as app | ||||||
else: | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you import the other GRPC warning instead of duplicating ?