Skip to content

FEAT: Assign wave port in Driven Terminal #6358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 10, 2025
Merged

Conversation

Samuelopez-ansys
Copy link
Member

Description

Assign wave port in driven terminal is available since 2024R1.

Issue linked

Close #6357

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

# Conflicts:
#	src/ansys/aedt/core/hfss.py
#	tests/system/general/test_20_HFSS.py
@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner July 7, 2025 09:08
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Jul 7, 2025
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (710ce3a) to head (17f98bc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6358      +/-   ##
==========================================
- Coverage   85.36%   85.36%   -0.01%     
==========================================
  Files         175      175              
  Lines       65989    65980       -9     
==========================================
- Hits        56333    56321      -12     
- Misses       9656     9659       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys merged commit e1f9211 into main Jul 10, 2025
37 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_6357 branch July 10, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add creation of modal waveport in driven terminal designs
3 participants