-
Notifications
You must be signed in to change notification settings - Fork 193
FEAT: Install pyaedt via uv #6338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FEAT: Install pyaedt via uv #6338
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6338 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 242 242
Lines 76995 76995
=======================================
+ Hits 63401 63402 +1
+ Misses 13594 13593 -1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give a try at making the whole project moving to uv instead of only this installation file ? Also, could you consider using UV_HTTP_TIMEOUT
in order to keep the previous behavior with ``--default-timeout` ? It has a larger scope but if I understand well the documentation it should be helping for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some comments, thanks for the contribution !
Note that we might have issues when using pyaedt
with uv
. In particular for those still leveraging the dotnet
target.
See ansys/pymechanical#1143 and the associated uv issue astral-sh/python-build-standalone#596
…-to-use-uv-package-manager
Should we merge this PR? PyAEDT issues using uv can be avoided creating the venv in the traditional way and installing packages via uv. With the actual implementation should work fine |
@eblanco-ansys The main issue is about the offline installation. Is this solved? If uv is not installed in the venv , how the offline installation would work? We could add uv to the dependencies of pyaedt or at least to the wheelhouses @SMoraisAnsys any thoughts? |
Adding |
…-to-use-uv-package-manager
All the previous concerns were related to how the venv is created. If we create the venv in the traditional way and install everything via uv, it should be fine. @tusharbana-ansys figured out this workaround |
…-to-use-uv-package-manager
Description
Use uv to install pyaedt dependencies. Implemented changes
python -m venv
until Package seems not to work pymechanical#1143 and the associated uv issue Windows: OpenSSL installed DLL name differs from CPython, affecting extension modules astral-sh/python-build-standalone#596 are resolveduv
is installed firstly and the other packages are installed viauv pip install
(a lot faster)uv
is intalled firstly. We then useuv
to install the other packages inside the wheel.With these changes we reduce a lot the overall installation time, up to 5 times.
Other minor changes:
Issue linked
#6317
Checklist