Skip to content

Conversation

eblanco-ansys
Copy link
Contributor

@eblanco-ansys eblanco-ansys commented Jun 30, 2025

Description

Use uv to install pyaedt dependencies. Implemented changes

Other minor changes:

  • Unzip function now supports recursivity. For dev wheelhouses, when the file is unzipped there is another zip inside the unzipped folder. This should be solved in the github action, this is a workaround.
  • Files are unzipped in a temporal directory

Issue linked

#6317

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.34%. Comparing base (0a3d352) to head (aa2912d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6338   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files         242      242           
  Lines       76995    76995           
=======================================
+ Hits        63401    63402    +1     
+ Misses      13594    13593    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a try at making the whole project moving to uv instead of only this installation file ? Also, could you consider using UV_HTTP_TIMEOUT in order to keep the previous behavior with ``--default-timeout` ? It has a larger scope but if I understand well the documentation it should be helping for this.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments, thanks for the contribution !
Note that we might have issues when using pyaedt with uv. In particular for those still leveraging the dotnet target.
See ansys/pymechanical#1143 and the associated uv issue astral-sh/python-build-standalone#596

@eblanco-ansys eblanco-ansys marked this pull request as ready for review July 8, 2025 15:52
@eblanco-ansys eblanco-ansys requested a review from a team as a code owner July 8, 2025 15:52
@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft July 24, 2025 09:05
@eblanco-ansys
Copy link
Contributor Author

Should we merge this PR? PyAEDT issues using uv can be avoided creating the venv in the traditional way and installing packages via uv. With the actual implementation should work fine

@Samuelopez-ansys
Copy link
Member

@eblanco-ansys The main issue is about the offline installation. Is this solved?

If uv is not installed in the venv , how the offline installation would work? We could add uv to the dependencies of pyaedt or at least to the wheelhouses

@SMoraisAnsys any thoughts?

@SMoraisAnsys
Copy link
Collaborator

@eblanco-ansys The main issue is about the offline installation. Is this solved?

If uv is not installed in the venv , how the offline installation would work? We could add uv to the dependencies of pyaedt or at least to the wheelhouses

@SMoraisAnsys any thoughts?

Adding uv to the all target wheelhouse would be a solution considering the current approach and how to address offline installation. Are all the previously mentioned concerns addressed ?

@eblanco-ansys
Copy link
Contributor Author

@eblanco-ansys The main issue is about the offline installation. Is this solved?
If uv is not installed in the venv , how the offline installation would work? We could add uv to the dependencies of pyaedt or at least to the wheelhouses
@SMoraisAnsys any thoughts?

Adding uv to the all target wheelhouse would be a solution considering the current approach and how to address offline installation. Are all the previously mentioned concerns addressed ?

All the previous concerns were related to how the venv is created. If we create the venv in the traditional way and install everything via uv, it should be fine. @tusharbana-ansys figured out this workaround

@eblanco-ansys eblanco-ansys marked this pull request as ready for review September 15, 2025 14:41
@github-actions github-actions bot added the maintenance Package and maintenance related label Sep 15, 2025
@eblanco-ansys eblanco-ansys self-assigned this Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the 'PyAEDT Installer Python file' to use 'uv' package manager
5 participants