FEAT: Install pyaedt via uv #6338
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6338 +/- ##
==========================================
- Coverage 84.27% 81.96% -2.31%
==========================================
Files 175 175
Lines 65983 65983
==========================================
- Hits 55606 54083 -1523
- Misses 10377 11900 +1523 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Could you give a try at making the whole project moving to uv instead of only this installation file ? Also, could you consider using UV_HTTP_TIMEOUT in order to keep the previous behavior with ``--default-timeout` ? It has a larger scope but if I understand well the documentation it should be helping for this.
There was a problem hiding this comment.
Here are some comments, thanks for the contribution !
Note that we might have issues when using pyaedt with uv. In particular for those still leveraging the dotnet target.
See ansys/pymechanical#1143 and the associated uv issue astral-sh/python-build-standalone#596
| env = os.environ.copy() | ||
| env["VIRTUAL_ENV"] = str(venv_dir) | ||
| env["PATH"] = str(venv_dir / "Scripts") + os.pathsep + env.get("PATH", "") | ||
| env["UV_HTTP_TIMEOUT "] = "1000" # Increase timeout for uv |
There was a problem hiding this comment.
| env["UV_HTTP_TIMEOUT "] = "1000" # Increase timeout for uv | |
| env["UV_HTTP_TIMEOUT"] = "1000" # Increase timeout for uv |
|
|
||
| if args.version <= "231": | ||
| subprocess.run([str(pip_exe), "uninstall", "-y", "pywin32"], check=True) # nosec | ||
| subprocess.run([str(uv_exe), "pip", "uninstall", "-y", "pywin32"], check=True, env=env) # nosec |
There was a problem hiding this comment.
| subprocess.run([str(uv_exe), "pip", "uninstall", "-y", "pywin32"], check=True, env=env) # nosec | |
| subprocess.run([str(uv_exe), "pip", "uninstall", "-y", "pywin32"], check=True) # nosec |
Not defined here
| subprocess.call([str(pip_exe), "uninstall", "-y", "pyaedt"], check=True) # nosec | ||
| # Ensure uv is installed in the venv | ||
| subprocess.run([str(pip_exe), "install", "uv"], check=True) # nosec | ||
| subprocess.call([str(uv_exe), "pip", "uninstall", "-y", "pyaedt"], check=True, env=env) # nosec |
There was a problem hiding this comment.
| subprocess.call([str(uv_exe), "pip", "uninstall", "-y", "pyaedt"], check=True, env=env) # nosec | |
| subprocess.call([str(uv_exe), "pip", "uninstall", "-y", "pyaedt"], check=True) # nosec |
Not defined here
| @@ -301,16 +314,16 @@ def install_pyaedt(): | |||
| command.append("pyaedt[all,dotnet]=='0.9.0'") | |||
| else: | |||
| command.append("pyaedt[all]") | |||
| subprocess.run(command, check=True) # nosec | |||
| subprocess.run(command, check=True, env=env) # nosec | |||
There was a problem hiding this comment.
| subprocess.run(command, check=True, env=env) # nosec | |
| subprocess.run(command, check=True) # nosec |
| else: | ||
| print("Installing PyAEDT using online sources") | ||
| print("Installing PyAEDT using online sources with uv...") |
There was a problem hiding this comment.
You need to define the env variable here too or possibly sooner in your script.
…-to-use-uv-package-manager
Description
Use uv to install pyaedt dependencies
Issue linked
#6317
Checklist