Skip to content

FEAT: emit_schematic_feature #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: F932911
Choose a base branch
from
Open

FEAT: emit_schematic_feature #6249

wants to merge 10 commits into from

Conversation

ramin4667
Copy link
Contributor

Description

This PR adds the schematic module to the feature branch F932911.

Issue linked

NA.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ramin4667 ramin4667 requested a review from a team as a code owner June 9, 2025 19:44
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 26.72689% with 1379 lines in your changes missing coverage. Please review.

Please upload report for BASE (F932911@2a1ac4f). Learn more about missing BASE report.

❌ Your patch check has failed because the patch coverage (26.72%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             F932911    #6249   +/-   ##
==========================================
  Coverage           ?   38.40%           
==========================================
  Files              ?      286           
  Lines              ?    76624           
  Branches           ?        0           
==========================================
  Hits               ?    29424           
  Misses             ?    47200           
  Partials           ?        0
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ramin4667 ramin4667 requested a review from jsalant22 June 10, 2025 19:40
@jsalant22
Copy link
Contributor

@ramin4667 Can you take a look at the merge conflicts? Since they're all in the generated nodes, I'm guessing we want to accept all the changes from the main feature branch.

ramin4667 added 5 commits June 13, 2025 13:24
@ramin4667
Merge remote-tracking branch 'origin/F932911' into emit_schematic_fea…
f1f68ff 
…ture

# Conflicts:
#	src/ansys/aedt/core/emit_core/nodes/generated/antenna_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/band.py
#	src/ansys/aedt/core/emit_core/nodes/generated/band_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/cad_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/circulator.py
#	src/ansys/aedt/core/emit_core/nodes/generated/coupling_link_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/coupling_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/custom_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/emi_plot_marker_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/erceg_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/five_g_channel_model.py
#	src/ansys/aedt/core/emit_core/nodes/generated/hata_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/indoor_propagation_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/isolator.py
#	src/ansys/aedt/core/emit_core/nodes/generated/log_distance_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/mplex_band_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/multiplexer.py
#	src/ansys/aedt/core/emit_core/nodes/generated/outboard_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/parametric_coupling_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/plot_marker_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/plot_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/power_divider.py
#	src/ansys/aedt/core/emit_core/nodes/generated/power_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/profile_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/propagation_loss_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_antenna_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_band.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_cad_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_circulator.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_coupling_link_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_custom_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_erceg_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_five_g_channel_model.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_hata_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_indoor_propagation_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_isolator.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_log_distance_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_multiplexer.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_power_divider.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_propagation_loss_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_rx_meas_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_rx_selectivity_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_rx_susceptibility_prof_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_sampling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_scene_group_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_solution_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_solutions_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_touchstone_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_tr_switch.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_two_ray_path_loss_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_tx_bb_emission_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_tx_meas_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_tx_spectral_prof_emitter_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_tx_spectral_prof_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_walfisch_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/read_only_waveform.py
#	src/ansys/aedt/core/emit_core/nodes/generated/result_plot_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/rx_meas_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/rx_selectivity_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/rx_susceptibility_prof_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/sampling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/scene_group_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/selectivity_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/solution_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/solutions_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/spur_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/test_noise_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/touchstone_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/tr_switch.py
#	src/ansys/aedt/core/emit_core/nodes/generated/tr_switch_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/tunable_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/two_ray_path_loss_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/two_tone_trace_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/tx_bb_emission_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/tx_meas_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/tx_spectral_prof_emitter_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/tx_spectral_prof_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/walfisch_coupling_node.py
#	src/ansys/aedt/core/emit_core/nodes/generated/waveform.py
@ramin4667
id is replaced by comp_id
0726357
@ramin4667
true value correction
e1b5f4d
@ramin4667
id replacement with comp_id
66c72cf
@ramin4667
more id replacement with comp_id
5840e0a
@ramin4667
Copy link
Contributor Author

@ramin4667 Can you take a look at the merge conflicts? Since they're all in the generated nodes, I'm guessing we want to accept all the changes from the main feature branch.

@jsalant22 conflicts are solved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsalant22 jsalant22 jsalant22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramin4667 @jsalant22 @pyansys-ci-bot