Skip to content

Fix OpenAPI schema validation message mismatch#16367

Closed
tvo318 wants to merge 3 commits intoansible:develfrom
tvo318:valid-openapi
Closed

Fix OpenAPI schema validation message mismatch#16367
tvo318 wants to merge 3 commits intoansible:develfrom
tvo318:valid-openapi

Conversation

@tvo318
Copy link
Copy Markdown
Member

@tvo318 tvo318 commented Mar 24, 2026

Summary

  • Fixed mismatch between validation check message and actual output
  • Workflow now correctly detects when OpenAPI schema validation passes
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

Details

The GitHub Actions workflow at .github/workflows/api_schema_check.yml:66 checks for the message "✓ Schema is valid", but the Makefile was printing "✓ OpenAPI Schema is valid!". This mismatch caused the workflow to always report validation as FAILED even when the schema was actually valid.

Updated Makefile:584 to print the exact message the workflow expects, ensuring proper detection of successful validation.

Test plan

  • Code change reviewed
  • Verify workflow correctly shows validation passing when schema is valid
  • Verify workflow correctly shows validation failing when schema is invalid

🤖 Generated with Claude Code


Note

Low Risk
One-line output change in a Makefile target; no runtime behavior changes beyond CI log matching.

Overview
Updates make validate-openapi-schema to print the success string ✓ Schema is valid (instead of ✓ OpenAPI Schema is valid!) so the api_schema_check GitHub Actions workflow correctly detects and reports passing OpenAPI schema validation.

Written by Cursor Bugbot for commit 43c8626. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated the OpenAPI schema validation success message for improved clarity.

The workflow checks for "✓ Schema is valid" but the Makefile was
printing "✓ OpenAPI Schema is valid!", causing validation to always
appear failed even when the schema was valid. Updated the Makefile
to print the exact message the workflow expects.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Walkthrough

The validate-openapi-schema Makefile target's success message was updated from "✓ OpenAPI Schema is valid!" to "✓ Schema is valid". No functional changes to validation logic or error handling were made.

Changes

Cohort / File(s) Summary
Makefile
Makefile
Updated success message text in the validate-openapi-schema target from "✓ OpenAPI Schema is valid!" to "✓ Schema is valid".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a mismatch between the validation message printed by the Makefile and the message expected by the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tvo318 tvo318 requested a review from Jaapis March 24, 2026 14:55
@tvo318 tvo318 requested a review from fosterseth March 24, 2026 21:37
@sonarqubecloud
Copy link
Copy Markdown

@tvo318
Copy link
Copy Markdown
Member Author

tvo318 commented Mar 25, 2026

Closing this PR and start new one with signed SSH key.

@tvo318 tvo318 closed this Mar 25, 2026
@tvo318 tvo318 deleted the valid-openapi branch March 25, 2026 17:06
@tvo318
Copy link
Copy Markdown
Member Author

tvo318 commented Mar 25, 2026

See #16372 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants