Fix OpenAPI schema validation message mismatch#16367
Closed
tvo318 wants to merge 3 commits intoansible:develfrom
Closed
Fix OpenAPI schema validation message mismatch#16367tvo318 wants to merge 3 commits intoansible:develfrom
tvo318 wants to merge 3 commits intoansible:develfrom
Conversation
The workflow checks for "✓ Schema is valid" but the Makefile was printing "✓ OpenAPI Schema is valid!", causing validation to always appear failed even when the schema was valid. Updated the Makefile to print the exact message the workflow expects. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Jaapis
approved these changes
Mar 24, 2026
fosterseth
approved these changes
Mar 25, 2026
|
Member
Author
|
Closing this PR and start new one with signed SSH key. |
Member
Author
|
See #16372 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
ISSUE TYPE
COMPONENT NAME
Details
The GitHub Actions workflow at
.github/workflows/api_schema_check.yml:66checks for the message "✓ Schema is valid", but the Makefile was printing "✓ OpenAPI Schema is valid!". This mismatch caused the workflow to always report validation as FAILED even when the schema was actually valid.Updated
Makefile:584to print the exact message the workflow expects, ensuring proper detection of successful validation.Test plan
🤖 Generated with Claude Code
Note
Low Risk
One-line output change in a Makefile target; no runtime behavior changes beyond CI log matching.
Overview
Updates
make validate-openapi-schemato print the success string✓ Schema is valid(instead of✓ OpenAPI Schema is valid!) so theapi_schema_checkGitHub Actions workflow correctly detects and reports passing OpenAPI schema validation.Written by Cursor Bugbot for commit 43c8626. This will update automatically on new commits. Configure here.
Summary by CodeRabbit