-
Notifications
You must be signed in to change notification settings - Fork 700
Update meta.json #4676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update meta.json #4676
Conversation
Fix to obvious schema issues. There are others less straightforward to fix, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I do not see these errors as obvious. If you can add at least one positive/negative tests, it would much easier to understand them and also to prevent further changes that might break the schema.
The current schema itself is obviously wrong because what is written does not make sense from a semantical point of view. However, how to fix it depends on the underlying intention which failed to materialize in the schema, and is really just guessing from my part because I do not know the real/detailed expectations. For these two fixes on the meta json file, which seems to correspond more or less to this description and this other:
What is really expected can probably be infered from the source code of the ansible commands which uses the described data structure. The 2 other issues I reported in #4660 have a strange schema semantics which demonstrates that writing schemas is error prone, but I could not make an easy guess about what the schema writer had in mind.
I am sorry, I was just planing to point out bugs in a schema, not to do debugging in an unfamiliar environment. |
- Attempt at having a sane semantics on `GalaxyInfo` conditionals. - Simply remove strange `additionalProperties` inside a `properties`.
I've updated the GalaxyInfo structure to have a conditional with a clearer semantics and remove the strangeness. Tox does not like it because it seems to actually check the strange ❓ what is the actual expectation when |
if not standalone, we interpret the previous schema as "these props are forbidden", which is not the same as "these props are forbidden when they are all together".
Fix to obvious schema issues. There are others less straightforward to fix, though.