Skip to content

Add example of unintentional None to 2.19 porting guide #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein added the backport-2.19 Automatically create a backport for the stable-2.19 branch label Aug 11, 2025
@felixfontein
Copy link
Collaborator Author

@samccann
Copy link
Contributor

@felixfontein @mattclay - looks like the referenced issue suggests some of this is updated in the next core 2.19 version. Is the content in this PR update still valid?

@felixfontein felixfontein marked this pull request as draft August 15, 2025 17:54
@felixfontein
Copy link
Collaborator Author

I was planning to check whether the PR mentioned there (ansible/ansible#85652) changed something, but only got to do that now. It actually does (the first string_with_none now is a stringified list without the Nones). Since according to ansible/ansible#85605 (comment) the new behavior isn't fixed it's better to wait until that's finalized.

CC @nitzmahone please add a comment here if/when you decide to change something :)

@mattclay
Copy link
Member

The fixes in ansible/ansible#85652 and ansible/ansible#85676 resolve the issue with concatenation of None resulting in a literal None in the template output. These fixes are being backported (ansible/ansible#85663) and will be included in 2.19.1.

@felixfontein
Copy link
Collaborator Author

I'll rewrite this accordingly somewhen this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.19 Automatically create a backport for the stable-2.19 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants