Added version.txt file to package_data in call to setuptools.setup #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setup.py script so that it is discoverable after pip installation
Owner
|
Hi Abhinav, thanks for this. I will get back to you by end of day today. |
Author
|
Hi @anoopkunchukuttan, any update on this? |
Author
|
Hi @anoopkunchukuttan, any update on this? It is really a very simple fix, would be greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary so that the version.txt file is discoverable to the setup.py script after pip installation. Otherwise, programs like conda forge's setup scripts that run setup.py during package installation will error out.
Please see #63 for more context.
@anoopkunchukuttan I would appreciate if you could merge this and publish to Pypi ASAP so that I can make this available via conda forge. Thank you.