Fix: Ensure bridge task main is called correctly in dev#6707
Open
achadha235 wants to merge 1 commit intoanomalyco:devfrom
Open
Fix: Ensure bridge task main is called correctly in dev#6707achadha235 wants to merge 1 commit intoanomalyco:devfrom
main is called correctly in dev#6707achadha235 wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Currently, if you define a task with either
commandand / orentrypointand runsst dev, the bridge task definition is created incorrectly with the custom command. This prevents the bridgemainfrom being executed and the task does not work.Expected Behavior: When a bridge task is created in
dev, we should always get/app/mainas the command in the task definition so that the tunneling / forwarding functionality works.Fix: The cause was the spread operator in
v[0]in/aws/task.ts. Added code to ensurecommandandentrypointare not passed on in dev mode.