chore: replace zip-local with adm-zip#2879
Merged
thdxr merged 1 commit intoanomalyco:masterfrom May 17, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: eab391e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
thank you! |
This was referenced May 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zip-local package has dependencies with security vulnerabilities:
There is an open pull request on zip-local to fix this (Mostafa-Samir/zip-local#18), but it's two weeks old and the maintainer has not reacted to it. Maybe it's easier to just use adm-zip instead, since it's already in the deps anyway.
I have tried to verify that it's still possible to build java functions, but my experience with Java in Lambda is nil, so I might have broken something.