feat(solid): expose terminal focus events via hooks#811
Merged
simonklee merged 3 commits intoanomalyco:mainfrom Mar 20, 2026
Merged
feat(solid): expose terminal focus events via hooks#811simonklee merged 3 commits intoanomalyco:mainfrom
simonklee merged 3 commits intoanomalyco:mainfrom
Conversation
nybble73
requested review from
Adictya,
Hona,
kommander,
msmps and
simonklee
as code owners
nybble73
force-pushed
the
feat/terminal-focus-hooks
branch
from
3b3de26 to
e041239
Compare
simonklee
reviewed
Mar 14, 2026
nybble73
force-pushed
the
feat/terminal-focus-hooks
branch
from
d36595a to
5332607
Compare
simonklee
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #766
The renderer already emits
"focus"and"blur"events when the terminal window gains/loses focus (via DECSET 1004), but there's no way to consume them from the SolidJS layer.This adds three hooks following existing patterns:
onFocus(callback)/onBlur(callback)— callback style, mirrorsonResizeuseTerminalFocus()→Accessor<boolean>— signal style, mirrorsuseTerminalDimensionsUse case: opencode plugins need to know if the user is looking at the terminal to decide whether to send OS notifications. Currently done via osascript polling — this replaces it with the event-driven signal the terminal already provides.