feat(diff): add public isHighlighting getter to DiffRenderable#795
Open
remorses wants to merge 2 commits intoanomalyco:mainfrom
Open
feat(diff): add public isHighlighting getter to DiffRenderable#795remorses wants to merge 2 commits intoanomalyco:mainfrom
remorses wants to merge 2 commits intoanomalyco:mainfrom
Conversation
Exposes whether tree-sitter syntax highlighting is currently in progress on either side of the diff. This lets consumers (like test renderers or batch HTML generators) wait for highlighting to complete deterministically instead of polling with arbitrary timeouts. The getter checks isHighlighting on both left and right CodeRenderable instances, returning true if either is still processing.
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
There was a problem hiding this comment.
Pull request overview
Adds a public isHighlighting accessor to DiffRenderable so external consumers can determine when tree-sitter highlighting is still running and wait deterministically.
Changes:
- Introduces
DiffRenderable.isHighlighting, delegating to the underlying left/rightCodeRenderable.isHighlightingstate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a public
isHighlightinggetter toDiffRenderablethat returnstruewhen tree-sitter syntax highlighting is in progress on either side of the diff.This enables consumers like test renderers and batch HTML generators to wait for highlighting deterministically — check
diffRenderable.isHighlightingin a loop instead of pollingrequestRenderwith arbitrary timeouts.The getter delegates to
CodeRenderable.isHighlightingon both left and right code renderables, which is already tracked internally by_waitingForHighlight+handleLineInfoChange.