Fix markdown CodeRenderable illegible in light theme#717
Open
NicoDeVeaux wants to merge 4 commits intoanomalyco:mainfrom
Open
Fix markdown CodeRenderable illegible in light theme#717NicoDeVeaux wants to merge 4 commits intoanomalyco:mainfrom
NicoDeVeaux wants to merge 4 commits intoanomalyco:mainfrom
Conversation
added 2 commits
February 20, 2026 18:35
NicoDeVeaux
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
NicoDeVeaux
changed the title
kommander
reviewed
Feb 24, 2026
| } | ||
|
|
||
| private getCodeFallbackStyle(): StyleDefinition | undefined { | ||
| return this.getStyle("markup.raw.block") || this.getStyle("markup.raw") || this.getStyle("default") |
Collaborator
There was a problem hiding this comment.
This is language/parser/query specific and not generic enough. There is the default style, isn't that enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when in light mode, CodeRenderable text was rendered white on white: it was illegible.
This updates markdown.ts to:
Includes simple unit tests