fix(core): treat 0 tty cols/rows as invalid#687
Open
remorses wants to merge 6 commits intoanomalyco:mainfrom
Open
fix(core): treat 0 tty cols/rows as invalid#687remorses wants to merge 6 commits intoanomalyco:mainfrom
remorses wants to merge 6 commits intoanomalyco:mainfrom
Conversation
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
There was a problem hiding this comment.
Pull request overview
Adjusts CliRenderer terminal dimension initialization to avoid propagating invalid 0 values for TTY size (notably observed in Bun-compiled binaries), preventing downstream invalid buffer sizing.
Changes:
- Treat non-positive
stdout.columns/stdout.rowsas invalid duringCliRendererconstruction. - Fall back to the renderer’s initial
width/heightwhen terminal dimensions are missing or invalid.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fall back to current terminal dimensions instead of hardcoded 80x24 when SIGWINCH fires with invalid values.
simonklee
previously approved these changes
Feb 14, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TTY streams can report terminal
columns/rowsas 0 even whileisTTYis true.CliRenderer currently uses nullish fallback (
??) when assigning terminal dimensions, which preserves the invalid 0 values and can cascade into invalid buffer dimensions.This change treats non-positive values as invalid and falls back to the renderer’s initial dimensions. No behavior change when columns/rows are already sane (> 0).