fix(text-buffer): recalculate rope segment widths on tab width change#658
Open
simonklee wants to merge 2 commits intoanomalyco:mainfrom
Open
fix(text-buffer): recalculate rope segment widths on tab width change#658simonklee wants to merge 2 commits intoanomalyco:mainfrom
simonklee wants to merge 2 commits intoanomalyco:mainfrom
Conversation
simonklee
requested review from
Hona,
kitlangton,
kommander and
msmps
as code owners
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
simonklee
force-pushed
the
set-tab-width-rebuild
branch
from
e0fe279 to
556ebf3
Compare
simonklee
force-pushed
the
set-tab-width-rebuild
branch
2 times, most recently
from
0d7a216 to
5599ef5
Compare
When tab width changes, rebuild rope segments with recomputed chunk widths before updating tab_width so line metrics and total width stay consistent.
simonklee
force-pushed
the
set-tab-width-rebuild
branch
from
81ce877 to
d496e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tab width changes, rebuild rope segments with recomputed chunk widths before updating tab_width so line metrics and total width stay consistent.