Skip to content

fix(tui): clear answer editing state when selecting other options #44240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniruddhaadak80 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(tui): clear answer editing state when selecting other options #44240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/tui/src/routes/session/question.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ export function QuestionPrompt(props: { request: QuestionRequest; directory?: st
function selectTab(index: number) {
setStore("tab", index)
setStore("selected", 0)
// Mouse handlers switch tabs while the custom-answer editor is open; stale editing
// state would keep Return bound to the editor on the new tab.
setStore("editing", false)
}

function selectOption() {
Expand All @@ -118,6 +121,9 @@ export function QuestionPrompt(props: { request: QuestionRequest; directory?: st
}
const opt = options()[store.selected]
if (!opt) return
// Mouse handlers reach this while the custom-answer editor is open; leaving it enabled
// keeps Return bound to the editor instead of submit/confirm.
setStore("editing", false)
if (multi()) {
toggle(opt.label)
return
Expand Down
Loading