fix(glob): match explicitly requested dot directories#32907
Closed
dannyward630 wants to merge 1 commit into
Closed
fix(glob): match explicitly requested dot directories#32907dannyward630 wants to merge 1 commit into
dannyward630 wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Recommendation: Check if PR #32866 is already merged or still open. If it's still open, one of these PRs may be redundant and should be closed in favor of the other. |
Author
|
Closing as duplicate of #32866, which already covers explicit dot-directory glob support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #32669
Type of change
What does this PR do?
Allows the Glob tool to match files under dot directories when the user explicitly asks for one, such as
.ai/**/*.mdor a search path inside.ai.The tool now enables ripgrep hidden-file scanning only when the requested glob pattern or search path includes a dot-directory segment, so ordinary patterns like
*.mdkeep the previous default behavior.How did you verify your code works?
npx --yes bun@1.3.14 test test/tool/glob.test.tsnpx --yes bun@1.3.14 run typecheckScreenshots / recordings
Not a UI change.
Checklist