fix(config): normalize Windows env paths in config tokens#32906
Open
dannyward630 wants to merge 1 commit into
Open
fix(config): normalize Windows env paths in config tokens#32906dannyward630 wants to merge 1 commit into
dannyward630 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #32695
Type of change
What does this PR do?
Normalizes native Windows path separators in
{env:...}config substitutions before JSONC parsing sees them. This keeps permission keys such as{env:MYDIR}/**parseable whenMYDIRis set to a Windows path likeC:\Users\me\..., while leaving non-path env values unchanged.Adds a regression test that loads a config with a Windows-style env var inside
permission.external_directoryand verifies the resulting rule uses forward slashes.How did you verify your code works?
npx --yes bun@1.3.14 test test/config/config.test.tsnpx --yes bun@1.3.14 run typecheckScreenshots / recordings
Not a UI change.
Checklist