Skip to content

fix(session): handle missing binary attachments#32889

Open
dannyward630 wants to merge 1 commit into
anomalyco:devfrom
dannyward630:binary-attachment-missing
Open

fix(session): handle missing binary attachments#32889
dannyward630 wants to merge 1 commit into
anomalyco:devfrom
dannyward630:binary-attachment-missing

Conversation

@dannyward630

Copy link
Copy Markdown

Summary

  • handle binary attachment read failures with the same recoverable flow as text and directory attachments
  • publish a session error and add a synthetic read-failure message instead of converting the failure into a defect

Closes #32777

Verification

  • bun run typecheck from packages/opencode
  • full pre-push bun turbo typecheck

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

I found a highly related PR:

Potential Duplicate:

This PR appears to address the same issue as PR #32889. Both are about handling missing or unreadable binary file attachments gracefully. This could be a duplicate or closely related work that should be reviewed together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:compliance This means the issue will auto-close after 2 hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(session): unhandled PlatformError when binary file attachment does not exist

1 participant