fix(app): localize v2 prompt input placeholder#30681
Open
ulises-jeremias wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
contributor
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
@adamdotdevin 这个 PR 改动很小（+1/-1），能否帮忙 review 一下？谢谢 |
|
@adamdotdevin ���ã�PR #30681��fixes #30375��Ŀǰ��Ȼ OPEN���ܷ��������� review�������Ķ���С��+1/-1����ֻ�ǰ�д����Ӣ�� placeholder �滻Ϊ i18n key�� |
This was referenced Jun 8, 2026
* upstream/dev: (546 commits) chore: update nix node_modules hashes feat(oauth): unify OAuth callback browser pages (anomalyco#34025) chore: generate refactor(app): replace tab drag handling with dndkit (anomalyco#33880) refactor(app): use dropdown for project selector (anomalyco#33984) chore: update nix node_modules hashes fix(app): bump ghostty-web to prevent terminal resize hangs (anomalyco#34020) chore: generate feat(sdk): expose active sessions (anomalyco#33991) fix(sdk): wake embedded session execution (anomalyco#33992) refactor(opencode): stop legacy v2 event emission (anomalyco#33993) fix(ui): normalize tooltip trigger layout (anomalyco#33979) fix(app): suspend hidden terminal renderer (anomalyco#33990) fix(app): enable auto-accept in session settings (anomalyco#33974) tweak: hide MCP access token prefix (anomalyco#33711) fix(core): refine small model defaults (anomalyco#33926) feat(core): split MCP timeout configuration (anomalyco#33977) fix(app): simplify question prompt (anomalyco#33968) feat(llm): pass strict through tool definitions for Codex parity (anomalyco#33392) chore: generate ...
Contributor
Author
|
@adamdotdevin @Hona @Brendonovich Rebased onto latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30375
Type of change
What does this PR do?
In v2 layout mode, the prompt input used a hardcoded English placeholder:
Ask anything, / for commands, @ for context...That bypassed i18n and remained English for non-English users.
This PR replaces the hardcoded string with a localized key:
language.t("prompt.placeholder.simple")So the placeholder now follows the active UI language.
How did you verify your code works?
bun typecheck(frompackages/app)bun test src/components/prompt-input/placeholder.test.ts(frompackages/app)Screenshots / recordings
Not included.
Checklist