fix(config): correct directory config precedence so project overrides global#19376
Closed
MoerAI wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(config): correct directory config precedence so project overrides global#19376MoerAI wants to merge 1 commit intoanomalyco:devfrom
MoerAI wants to merge 1 commit intoanomalyco:devfrom
Conversation
… global The directories() function loaded home ~/.opencode configs AFTER project .opencode configs, giving global config higher precedence than project config. This contradicts the documented precedence order where project configs should override global defaults. Swap the order so home .opencode is merged first (as a base), then project .opencode is merged on top, giving project config the higher precedence as documented. Closes anomalyco#19296
github-actions
bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.opencodedirectory configs properly override home~/.opencodedirectory configsProblem
The
ConfigPaths.directories()function returned directories in this order:~/.config/opencode(global XDG config).opencodedirs (loaded first)~/.opencodedir (loaded last — overrides project!)Since configs are merged sequentially with later values overriding earlier ones, the home
~/.opencodeconfig incorrectly took precedence over the project.opencodeconfig. This contradicts the documented precedence order.Fix
Swap the order so home
~/.opencodeis loaded before project.opencode:~/.config/opencode(global XDG config)~/.opencodedir (loaded first — serves as base).opencodedirs (loaded last — overrides home)This matches the documented precedence where project configs override global defaults.
Reproduction
As described in the issue:
Closes #19296