Merged
Conversation
kitlangton
force-pushed
the
effect/skill-native
branch
from
20bee2e to
3e4ace7
Compare
… Effect Convert the Skill service's internal async helpers (add, scan, loadSkills) from plain async functions wrapped in Effect.promise to native Effect generators using Effect.fnUntraced. Yield Config.Service and Bus.Service directly instead of going through their async facades, and yield discovery.pull as a native Effect rather than bridging through Effect.runPromise.
kitlangton
force-pushed
the
effect/skill-native
branch
from
3e4ace7 to
0527080
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add,scan, andloadSkillsfrom async functions wrapped inEffect.promiseto native Effect generators usingEffect.fnUntracedConfig.ServiceandBus.Servicedirectly in the layer instead of calling their async facades (Config.get(),Config.directories(),Bus.publish())discovery.pull()as a native Effect instead of bridging throughEffect.runPromiseConfig.ServiceandBus.Serviceas explicit layer dependenciesTest plan
bun run typecheckpasses (no new errors introduced; pre-existing Effect version mismatch errors remain)